<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Tue, Jan 15, 2019 at 7:55 AM Iago Toral Quiroga <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">We are now using these bits, so don't assert that they are not set, just<br>
avoid compaction in that case.<br>
<br>
Reviewed-by: Topi Pohjolainen <<a href="mailto:topi.pohjolainen@intel.com" target="_blank">topi.pohjolainen@intel.com</a>><br>
---<br>
 src/intel/compiler/brw_eu_compact.c | 5 ++++-<br>
 1 file changed, 4 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/intel/compiler/brw_eu_compact.c b/src/intel/compiler/brw_eu_compact.c<br>
index ae14ef10ec0..20fed254331 100644<br>
--- a/src/intel/compiler/brw_eu_compact.c<br>
+++ b/src/intel/compiler/brw_eu_compact.c<br>
@@ -928,8 +928,11 @@ has_3src_unmapped_bits(const struct gen_device_info *devinfo,<br>
       assert(!brw_inst_bits(src, 127, 126) &&<br>
              !brw_inst_bits(src, 105, 105) &&<br>
              !brw_inst_bits(src, 84, 84) &&<br>
-             !brw_inst_bits(src, 36, 35) &&<br>
              !brw_inst_bits(src, 7,  7));<br>
+<br>
+      /* Src1Type and Src2Type, used for mixed-precision floating point */<br>
+      if (brw_inst_bits(src, 36, 35))<br>
+         return true;<br></blockquote><div><br></div><div>You're only doing this in the broadwell case.  What about SKL+ and CHV?  Can we compact mixed-precision stuff there?  Looks like maybe we can but there should be at least something in the commit message about that.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
    }<br>
<br>
    return false;<br>
-- <br>
2.17.1<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div></div>