<html dir="ltr"><head></head><body style="text-align:left; direction:ltr;"><div>Sure, I'll squash all 3.</div><div><br></div><div>On Thu, 2019-01-17 at 14:00 -0600, Jason Ekstrand wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div>This should probably be squashed into patch 7 so that it's clear from one patch that it's being properly handed on both sides of the gen9 boundary. I'd also squash in patch 15 and just give the whole thing the title "Handle extended math restrictions for half-float" with a detailed message describing what all we have to handle. If you want to keep it as two patches, that's fine but unnecessary.<br></div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jan 15, 2019 at 7:54 AM Iago Toral Quiroga <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>> wrote:<br></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">The PRM states that half-float operands are supported since gen9.<br>
<br>
Reviewed-by: Topi Pohjolainen <<a href="mailto:topi.pohjolainen@intel.com" target="_blank">topi.pohjolainen@intel.com</a>><br>
---<br>
src/intel/compiler/brw_eu_emit.c | 6 ++++--<br>
1 file changed, 4 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/intel/compiler/brw_eu_emit.c b/src/intel/compiler/brw_eu_emit.c<br>
index 45e2552783b..e21df4624b3 100644<br>
--- a/src/intel/compiler/brw_eu_emit.c<br>
+++ b/src/intel/compiler/brw_eu_emit.c<br>
@@ -1874,8 +1874,10 @@ void gen6_math(struct brw_codegen *p,<br>
assert(src1.file == BRW_GENERAL_REGISTER_FILE ||<br>
(devinfo->gen >= 8 && src1.file == BRW_IMMEDIATE_VALUE));<br>
} else {<br>
- assert(src0.type == BRW_REGISTER_TYPE_F);<br>
- assert(src1.type == BRW_REGISTER_TYPE_F);<br>
+ assert(src0.type == BRW_REGISTER_TYPE_F ||<br>
+ (src0.type == BRW_REGISTER_TYPE_HF && devinfo->gen >= 9));<br>
+ assert(src1.type == BRW_REGISTER_TYPE_F ||<br>
+ (src1.type == BRW_REGISTER_TYPE_HF && devinfo->gen >= 9));<br>
}<br>
<br>
/* Source modifiers are ignored for extended math instructions on Gen6. */<br>
</blockquote></div></blockquote></body></html>