<div dir="ltr"><div>Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>></div><div><br></div><div>Marek<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Feb 5, 2019 at 3:44 AM Nicolai Hähnle <<a href="mailto:nhaehnle@gmail.com">nhaehnle@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">From: Nicolai Hähnle <<a href="mailto:nicolai.haehnle@amd.com" target="_blank">nicolai.haehnle@amd.com</a>><br>
<br>
This field was added in a recent addrlib update, and while there<br>
currently seems to be no issue with skipping it, we will have to<br>
set it correctly in the future.<br>
---<br>
src/amd/common/ac_surface.c | 2 ++<br>
1 file changed, 2 insertions(+)<br>
<br>
diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c<br>
index 91004e032a3..27e63c318e6 100644<br>
--- a/src/amd/common/ac_surface.c<br>
+++ b/src/amd/common/ac_surface.c<br>
@@ -1135,20 +1135,21 @@ static int gfx9_compute_miptree(ADDR_HANDLE addrlib,<br>
hout.size = sizeof(ADDR2_COMPUTE_HTILE_INFO_OUTPUT);<br>
<br>
hin.hTileFlags.pipeAligned = !in->flags.metaPipeUnaligned;<br>
hin.hTileFlags.rbAligned = !in->flags.metaRbUnaligned;<br>
hin.depthFlags = in->flags;<br>
hin.swizzleMode = in->swizzleMode;<br>
hin.unalignedWidth = in->width;<br>
hin.unalignedHeight = in->height;<br>
hin.numSlices = in->numSlices;<br>
hin.numMipLevels = in->numMipLevels;<br>
+ hin.firstMipIdInTail = out.firstMipIdInTail;<br>
<br>
ret = Addr2ComputeHtileInfo(addrlib, &hin, &hout);<br>
if (ret != ADDR_OK)<br>
return ret;<br>
<br>
surf->u.gfx9.htile.rb_aligned = hin.hTileFlags.rbAligned;<br>
surf->u.gfx9.htile.pipe_aligned = hin.hTileFlags.pipeAligned;<br>
surf->htile_size = hout.htileBytes;<br>
surf->htile_slice_size = hout.sliceSize;<br>
surf->htile_alignment = hout.baseAlign;<br>
@@ -1201,20 +1202,21 @@ static int gfx9_compute_miptree(ADDR_HANDLE addrlib,<br>
din.colorFlags = in->flags;<br>
din.resourceType = in->resourceType;<br>
din.swizzleMode = in->swizzleMode;<br>
din.bpp = in->bpp;<br>
din.unalignedWidth = in->width;<br>
din.unalignedHeight = in->height;<br>
din.numSlices = in->numSlices;<br>
din.numFrags = in->numFrags;<br>
din.numMipLevels = in->numMipLevels;<br>
din.dataSurfaceSize = out.surfSize;<br>
+ din.firstMipIdInTail = out.firstMipIdInTail;<br>
<br>
ret = Addr2ComputeDccInfo(addrlib, &din, &dout);<br>
if (ret != ADDR_OK)<br>
return ret;<br>
<br>
surf->u.gfx9.dcc.rb_aligned = din.dccKeyFlags.rbAligned;<br>
surf->u.gfx9.dcc.pipe_aligned = din.dccKeyFlags.pipeAligned;<br>
surf->u.gfx9.dcc_pitch_max = dout.pitch - 1;<br>
surf->dcc_size = dout.dccRamSize;<br>
surf->dcc_alignment = dout.dccRamBaseAlign;<br>
-- <br>
2.19.1<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div>