<div dir="ltr"><div>If compute is used, graphics shaders don't need to be created.</div><div> </div><div>Marek </div></div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Feb 8, 2019 at 9:02 AM James Zhu <<a href="mailto:jamesz@amd.com">jamesz@amd.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> On 2019-02-08 6:33 a.m., Emil Velikov wrote: > On Thu, 7 Feb 2019 at 16:37, Zhu, James <<a href="mailto:James.Zhu@amd.com" target="_blank">James.Zhu@amd.com</a>> wrote: >> Add compute shader initilization, assign and cleanup in vl_compositor API. >> >> Signed-off-by: James Zhu <<a href="mailto:James.Zhu@amd.com" target="_blank">James.Zhu@amd.com</a>> >> Reviewed-by: Christian König <<a href="mailto:christian.koenig@amd.com" target="_blank">christian.koenig@amd.com</a>> >> --- >> src/gallium/auxiliary/vl/vl_compositor.c | 31 ++++++++++++++++++++++++++++++- >> src/gallium/auxiliary/vl/vl_compositor.h | 3 +++ >> 2 files changed, 33 insertions(+), 1 deletion(-) >> >> diff --git a/src/gallium/auxiliary/vl/vl_compositor.c b/src/gallium/auxiliary/vl/vl_compositor.c >> index 4509913..da4b02d 100644 >> --- a/src/gallium/auxiliary/vl/vl_compositor.c >> +++ b/src/gallium/auxiliary/vl/vl_compositor.c >> @@ -28,12 +28,31 @@ >> #include "util/u_sampler.h" >> >> #include "vl_compositor_gfx.h" >> +#include "vl_compositor_cs.h" >> >> static bool >> init_shaders(struct vl_compositor *c) >> { >> assert(c); >> >> + c->cs_video_buffer = vl_compositor_cs_create_shader(c, compute_shader_video_buffer); >> + if (!c->cs_video_buffer) { >> + debug_printf("Unable to create video_buffer compute shader.\n"); >> + return false; >> + } >> + >> + c->cs_weave_rgb = vl_compositor_cs_create_shader(c, compute_shader_weave); >> + if (!c->cs_weave_rgb) { >> + debug_printf("Unable to create weave_rgb compute shader.\n"); >> + return false; >> + } >> + >> + c->cs_rgba = vl_compositor_cs_create_shader(c, compute_shader_rgba); >> + if (!c->cs_rgba) { >> + debug_printf("Unable to create RGB-to-RGB compute shader.\n"); >> + return false; >> + } >> + > This constructs compute shaders even when we don't need them. > Can we have this behind a flag - say cs_compositor_render_enable or > something else? Yeah, I can add PIPE_CAP_COMPUTE check. James > > -Emil _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div>