<div dir="ltr"><div>Matt, Curro,</div><div><br></div><div>Could one of you please take a look at this and the other validator patches in this series? Region restrictions aren't my strongest area.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Feb 12, 2019 at 5:56 AM Iago Toral Quiroga <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The section 'Execution Data Types' of 3D Media GPGPU volume, which<br>
describes execution types, is exactly the same in BDW and SKL+.<br>
<br>
Also, this section states that there is a single execution type, so it<br>
makes sense that this is the wider of the two floating point types<br>
involved in mixed float mode, which is what we do for SKL+ and CHV.<br>
---<br>
src/intel/compiler/brw_eu_validate.c | 18 +++++++-----------<br>
1 file changed, 7 insertions(+), 11 deletions(-)<br>
<br>
diff --git a/src/intel/compiler/brw_eu_validate.c b/src/intel/compiler/brw_eu_validate.c<br>
index 358a0347a93..000a05cb6ac 100644<br>
--- a/src/intel/compiler/brw_eu_validate.c<br>
+++ b/src/intel/compiler/brw_eu_validate.c<br>
@@ -431,18 +431,14 @@ execution_type(const struct gen_device_info *devinfo, const brw_inst *inst)<br>
src1_exec_type == BRW_REGISTER_TYPE_DF)<br>
return BRW_REGISTER_TYPE_DF;<br>
<br>
- if (devinfo->gen >= 9 || devinfo->is_cherryview) {<br>
- if (dst_exec_type == BRW_REGISTER_TYPE_F ||<br>
- src0_exec_type == BRW_REGISTER_TYPE_F ||<br>
- src1_exec_type == BRW_REGISTER_TYPE_F) {<br>
- return BRW_REGISTER_TYPE_F;<br>
- } else {<br>
- return BRW_REGISTER_TYPE_HF;<br>
- }<br>
+ if (dst_exec_type == BRW_REGISTER_TYPE_F ||<br>
+ src0_exec_type == BRW_REGISTER_TYPE_F ||<br>
+ src1_exec_type == BRW_REGISTER_TYPE_F) {<br>
+ return BRW_REGISTER_TYPE_F;<br>
+ } else {<br>
+ assert(devinfo->gen >= 8 && src0_exec_type == BRW_REGISTER_TYPE_HF);<br>
+ return BRW_REGISTER_TYPE_HF;<br>
}<br>
-<br>
- assert(src0_exec_type == BRW_REGISTER_TYPE_F);<br>
- return BRW_REGISTER_TYPE_F;<br>
}<br>
<br>
/**<br>
-- <br>
2.17.1<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a></blockquote></div>