<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:fdo-bugs@engestrom.ch" title="Eric Engestrom <fdo-bugs@engestrom.ch>"> <span class="fn">Eric Engestrom</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - meson: more ensure that xmlpool_options.h is generated for targets that need it"
href="https://bugs.freedesktop.org/show_bug.cgi?id=109752">bug 109752</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - meson: more ensure that xmlpool_options.h is generated for targets that need it"
href="https://bugs.freedesktop.org/show_bug.cgi?id=109752#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - meson: more ensure that xmlpool_options.h is generated for targets that need it"
href="https://bugs.freedesktop.org/show_bug.cgi?id=109752">bug 109752</a>
from <span class="vcard"><a class="email" href="mailto:fdo-bugs@engestrom.ch" title="Eric Engestrom <fdo-bugs@engestrom.ch>"> <span class="fn">Eric Engestrom</span></a>
</span></b>
<pre>Hi David!
Thanks for your patch! I verified it and you are entirely correct :)
The preferred way to send patches for Mesa is by submitting a merge request
(<a href="https://gitlab.freedesktop.org/mesa/mesa/merge_requests">https://gitlab.freedesktop.org/mesa/mesa/merge_requests</a>, see
<a href="https://mesa3d.org/submittingpatches.html">https://mesa3d.org/submittingpatches.html</a>).
I just saw that you attached your patch, which I missed earlier, and I couldn't
manage to fixup the copy/pasted patch, so I rewrote it, added a few `Fixes:`
tags so that it gets picked up for backports, and pushed it as:
commit 6fa923a65daf1ee73c5cc763ade91abc82da7085
Author: David Shao <<a href="mailto:davshao@gmail.com">davshao@gmail.com</a>>
Date: Sun, 24 Feb 2019 09:00:36 +0000
meson: ensure that xmlpool_options.h is generated for gallium targets that
need it
Fixes: 68076b87474e7959c161 "meson: build gallium vdpau state tracker"
Fixes: 22a817af8a89eb3c762f "meson: build gallium xvmc state tracker"
Fixes: 5a785d51a6d68ec676ce "meson: build gallium va state tracker"
Fixes: 0ba909f0f111824223bc "meson: build gallium xa state tracker"
Fixes: 1d36dc674d528b93bec3 "meson: build gallium omx state tracker"
Reviewed-by: Eric Engestrom <<a href="mailto:eric.engestrom@intel.com">eric.engestrom@intel.com</a>>
Please double check the commit to make sure I didn't miss something :)
<a href="https://gitlab.freedesktop.org/mesa/mesa/commit/6fa923a65daf1ee73c5cc763ade91abc82da7085">https://gitlab.freedesktop.org/mesa/mesa/commit/6fa923a65daf1ee73c5cc763ade91abc82da7085</a>
Thanks again for your patch, and welcome to Mesa!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>