<div dir="ltr"><div>This is correct.  However, it's probably better to just replace most of that code with a call to nir_variable_create which will do everything in that block except set the data.read_only bit including the strdup (properly) and adding it to the list.</div><div><br></div><div>--Jason<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Feb 25, 2019 at 3:06 AM Tapani Pälli <<a href="mailto:tapani.palli@intel.com">tapani.palli@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Yep, confirmed that this plugs the leak.<br>
<br>
FWIW there seems to be also "Conditional jump or move depends on <br>
uninitialised value(s)" from valgrind but that is for something different.<br>
<br>
Reviewed-by: Tapani Pälli <<a href="mailto:tapani.palli@intel.com" target="_blank">tapani.palli@intel.com</a>><br>
<br>
On 2/21/19 11:09 AM, Matthias Lorenz wrote:<br>
> Fixes: 3d7611e9 "st/nir: use NIR for asm programs"<br>
> ---<br>
>   src/mesa/program/prog_to_nir.c | 3 ++-<br>
>   1 file changed, 2 insertions(+), 1 deletion(-)<br>
> <br>
> diff --git a/src/mesa/program/prog_to_nir.c b/src/mesa/program/prog_to_nir.c<br>
> index 312b299361e..6e3fa9432a3 100644<br>
> --- a/src/mesa/program/prog_to_nir.c<br>
> +++ b/src/mesa/program/prog_to_nir.c<br>
> @@ -1024,7 +1024,8 @@ prog_to_nir(const struct gl_program *prog,<br>
>         c->parameters = rzalloc(s, nir_variable);<br>
>         c->parameters->type =<br>
>            glsl_array_type(glsl_vec4_type(), prog->Parameters->NumParameters, 0);<br>
> -      c->parameters->name = strdup(prog->Parameters->Parameters[0].Name);<br>
> +      c->parameters->name =<br>
> +         ralloc_strdup(c->parameters, prog->Parameters->Parameters[0].Name);<br>
>         c->parameters->data.read_only = true;<br>
>         c->parameters->data.mode = nir_var_uniform;<br>
>         exec_list_push_tail(&s->uniforms, &c->parameters->node);<br>
> --<br>
> 2.20.1<br>
> <br>
> _______________________________________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
> <br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a></blockquote></div>