<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 10pt; color: rgb(0, 0, 0);">
Looks good.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 10pt; color: rgb(0, 0, 0);">
Reviewed-by: Neha Bhende <bhenden@vmware.com></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 10pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif">
<p style="margin-top: 0px; margin-bottom: 0px;"><span style="font-size:11pt; font-family:Calibri,Helvetica,sans-serif"></span><span style="font-size:10pt; font-family:Calibri,Helvetica,sans-serif">Regards,</span></p>
<span style="font-size:10pt"></span><span style="font-size:11pt; font-family:Calibri,Helvetica,sans-serif"></span><span style="font-size:10pt"></span>
<p style="margin-top: 0px; margin-bottom: 0px;"><span style="font-size:10pt; font-family:Calibri,Helvetica,sans-serif">Neha</span><br>
</p>
</div>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Brian Paul <brianp@vmware.com><br>
<b>Sent:</b> Monday, February 25, 2019 7:13 PM<br>
<b>To:</b> mesa-dev@lists.freedesktop.org<br>
<b>Cc:</b> Neha Bhende<br>
<b>Subject:</b> [PATCH] svga: fix dma.pending > 0 test</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">The dma.pending field is boolean, so testing for > 0 isn't right.<br>
---<br>
src/gallium/drivers/svga/svga_resource_buffer.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/gallium/drivers/svga/svga_resource_buffer.c b/src/gallium/drivers/svga/svga_resource_buffer.c<br>
index e4d12f0..a3e11ad 100644<br>
--- a/src/gallium/drivers/svga/svga_resource_buffer.c<br>
+++ b/src/gallium/drivers/svga/svga_resource_buffer.c<br>
@@ -117,7 +117,7 @@ svga_buffer_transfer_map(struct pipe_context *pipe,<br>
(void) svga_buffer_handle(svga, resource, sbuf->bind_flags);<br>
}<br>
<br>
- if (sbuf->dma.pending > 0) {<br>
+ if (sbuf->dma.pending) {<br>
svga_buffer_upload_flush(svga, sbuf);<br>
svga_context_finish(svga);<br>
}<br>
-- <br>
1.8.5.6<br>
<br>
</div>
</span></font></div>
</body>
</html>