<div dir="ltr">pushed.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Mar 11, 2019 at 3:15 PM Clayton Craft <<a href="mailto:clayton.a.craft@intel.com">clayton.a.craft@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, Mar 11, 2019 at 06:33:54PM +0100, Juan A. Suarez Romero wrote:<br>
>As stated in Vulkan spec:<br>
> "Resetting a descriptor pool recycles all of the resources from all<br>
> of the descriptor sets allocated from the descriptor pool back to<br>
> the descriptor pool, and the descriptor sets are implicitly freed."<br>
><br>
>This fixes dEQP-VK.api.descriptor_pool.*<br>
><br>
>Fixes: 14f6275c92f1 ("anv/descriptor_set: add reference counting for descriptor set layouts")<br>
<br>
I ran this though CI and these tests are no longer failing. I didn't see any<br>
regressions either.<br>
<br>
<br>
>CC: Tapani Pälli <<a href="mailto:tapani.palli@intel.com" target="_blank">tapani.palli@intel.com</a>><br>
>CC: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a>><br>
>CC: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>><br>
>---<br>
> src/intel/vulkan/anv_descriptor_set.c | 6 ++++++<br>
> 1 file changed, 6 insertions(+)<br>
><br>
>diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c<br>
>index f293cf469ee..f34a44aefd7 100644<br>
>--- a/src/intel/vulkan/anv_descriptor_set.c<br>
>+++ b/src/intel/vulkan/anv_descriptor_set.c<br>
>@@ -636,6 +636,12 @@ VkResult anv_ResetDescriptorPool(<br>
> }<br>
><br>
> anv_state_stream_finish(&pool->surface_state_stream);<br>
>+<br>
>+ list_for_each_entry_safe(struct anv_descriptor_set, set,<br>
>+ &pool->desc_sets, pool_link) {<br>
>+ anv_descriptor_set_destroy(device, pool, set);<br>
>+ }<br>
>+<br>
> anv_state_stream_init(&pool->surface_state_stream,<br>
> &device->surface_state_pool, 4096);<br>
> pool->surface_state_free_list = NULL;<br>
>-- <br>
>2.20.1<br>
><br>
>_______________________________________________<br>
>mesa-dev mailing list<br>
><a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
><a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
-----BEGIN PGP SIGNATURE-----<br>
<br>
iQIzBAABCAAdFiEEQ9xksAUlQz+rdXJEYJ7sVybntyAFAlyGwb0ACgkQYJ7sVybn<br>
tyBuBRAAiuXaaivM1CveLa7svwptOOV41hOmvtWWE75ziY0gMPd/p8Ks1sGkN7um<br>
BYfoAJUnJeMPKR5AblXX/IcmWL5yG/s8vnQu4DTASzDJnwJlcp7zN3qdBMUcMQuY<br>
2LD1UhjuWPNUF4MJFAHqQj7t6vBCM1CtqayhjNCghMRqaQRj3GIee+BDfwm1bUzZ<br>
1NYF7W83Gd7rK7yzj0Efbx8C4U0yO/PQYq3ddZlCACD/xLEoUgyjf4IwcOIexBtM<br>
0kCcb6ucrqhgLBvZhJRewGvuH2+DBIDzvaZ/AhQSKCLCr/O8HqAEY57TPOIlzNbI<br>
KgKbEqgJY83uuLqx60iW4bfs+ZtYLlh9HFsJKKrQvmXGbw9BlItPBkFsvFJ7kimo<br>
G6I7q4WAv3gBquTx6+hB4BmINwlHeEKqQU/U01y+95OAzjIg/8IlSB/QfvDDwtYC<br>
GPm8S+X6MTFUiYfHeatO9loIvAV2libS5LYGozUsYWAhcS6NrjIWQ3rHovcumFG2<br>
vhJxOn51Krwp+lPYX8D7ysJK8QGfs+v579TQ75cDdH5lb8xpyBI0cJBFA+Ov/LVI<br>
tyb9xDIsvX9yTrdZo5Bx9ujRdlaU0KkL/BbWlgUu5J3qhlQsk/e6lV+csNt2OvUv<br>
e4bwsxht2G1RrtQ+v7miBFO/FVuv5GvAtxr546b2x73GranmRUU=<br>
=fl2b<br>
-----END PGP SIGNATURE-----<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a></blockquote></div>