<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:baker.dylan.c@gmail.com" title="Dylan Baker <baker.dylan.c@gmail.com>"> <span class="fn">Dylan Baker</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - If DESTDIR is set to an empty string, the dri drivers are not installed"
href="https://bugs.freedesktop.org/show_bug.cgi?id=110211">bug 110211</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>FIXED
</td>
<td>---
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>RESOLVED
</td>
<td>REOPENED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - If DESTDIR is set to an empty string, the dri drivers are not installed"
href="https://bugs.freedesktop.org/show_bug.cgi?id=110211#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - If DESTDIR is set to an empty string, the dri drivers are not installed"
href="https://bugs.freedesktop.org/show_bug.cgi?id=110211">bug 110211</a>
from <span class="vcard"><a class="email" href="mailto:baker.dylan.c@gmail.com" title="Dylan Baker <baker.dylan.c@gmail.com>"> <span class="fn">Dylan Baker</span></a>
</span></b>
<pre>---
if os.path.isabs(args.libdir):
destdir=os.environ.get('DESTDIR','')
if len(destdir) == 0:
destdir = '/'
to = os.path.join(destdir, args.libdir[1:])
else:
...
Don't use len there, len() for testing emptiness is a python antipattern :)
just `if not destdir:`
However, I think doing something like
destdir = os.environ.get('DESTDIR')
to = args.libdir
if destdir
to = os.path.join(destdir, to)
is probably sufficient.
Just FYI, we don't do patch review in bugzilla, if you'd like to propose a
patch either an MR at gitlab.freedesktop.org/mesa/mesa or a patch sent to
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> is the proper way.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>