<html>
    <head>
      <base href="https://bugs.freedesktop.org/">
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - enable storageBuffer16BitAccess feature in radv for SI and CIK"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=110268">110268</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>enable storageBuffer16BitAccess feature in radv for SI and CIK
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>Mesa
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>unspecified
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>x86-64 (AMD64)
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Linux (All)
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>medium
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>Drivers/Vulkan/radeon
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>mesa-dev@lists.freedesktop.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>shuizhuyuanluo@126.com
          </td>
        </tr>

        <tr>
          <th>QA Contact</th>
          <td>mesa-dev@lists.freedesktop.org
          </td>
        </tr></table>
      <p>
        <div>
        <pre>the VK_KHR_16bit_storage extension is enabled but all features are reported as
FALSE for SI and CIK.

I found those features are only enabled with VI+ in
mesa/src/amd/vulkan/radv_device.c

as contrast, the amdvlk driver support them.

16bit storage support is important for reducing shader bandwidth and gaining
speed boost. (found 20%~50% speedup with the ncnn vulkan nerual network
benchmark)

please consider implementing storageBuffer16BitAccess feature for SI and CIK.

Thanks!


                case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES:
{
                        VkPhysicalDevice16BitStorageFeatures *features =
                            (VkPhysicalDevice16BitStorageFeatures*)ext;
                        bool enabled = pdevice->rad_info.chip_class >= VI;
                        features->storageBuffer16BitAccess = enabled;
                        features->uniformAndStorageBuffer16BitAccess = enabled;
                        features->storagePushConstant16 = enabled;
                        features->storageInputOutput16 = enabled && HAVE_LLVM
<span class="quote">>= 0x900;</span >
                        break;
                }</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the QA Contact for the bug.</li>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>