<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 4/16/19 4:21 PM, Marek Olšák wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAAxE2A6zt1BJGZKYCyi16GWfY_vXUVvjB5+NrphHR_Eq0qfibg@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr">
        <div>Reviewed-by: Marek Olšák <<a
            href="mailto:marek.olsak@amd.com" moz-do-not-send="true">marek.olsak@amd.com</a>></div>
      </div>
    </blockquote>
    Is the Rb for the whole series?<br>
    <blockquote type="cite"
cite="mid:CAAxE2A6zt1BJGZKYCyi16GWfY_vXUVvjB5+NrphHR_Eq0qfibg@mail.gmail.com">
      <div dir="ltr">
        <div><br>
        </div>
        <div>Marek<br>
        </div>
      </div>
      <br>
      <div class="gmail_quote">
        <div dir="ltr" class="gmail_attr">On Tue, Apr 16, 2019 at 2:27
          AM Samuel Pitoiset <<a
            href="mailto:samuel.pitoiset@gmail.com"
            moz-do-not-send="true">samuel.pitoiset@gmail.com</a>>
          wrote:<br>
        </div>
        <blockquote class="gmail_quote" style="margin:0px 0px 0px
          0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
          <div bgcolor="#FFFFFF">
            <p><br>
            </p>
            <div class="gmail-m_8153956321575916294moz-cite-prefix">On
              4/15/19 11:07 PM, Marek Olšák wrote:<br>
            </div>
            <blockquote type="cite">
              <div dir="ltr">
                <div class="gmail_quote">
                  <div dir="ltr" class="gmail_attr">On Mon, Apr 15, 2019
                    at 12:40 PM Samuel Pitoiset <<a
                      href="mailto:samuel.pitoiset@gmail.com"
                      target="_blank" moz-do-not-send="true">samuel.pitoiset@gmail.com</a>>
                    wrote:<br>
                  </div>
                  <blockquote class="gmail_quote" style="margin:0px 0px
                    0px 0.8ex;border-left:1px solid
                    rgb(204,204,204);padding-left:1ex">LLVM 9+ now
                    supports 8-bit and 16-bit types.<br>
                    <br>
                    v2: - rebase on master (without the vec3 change)<br>
                    <br>
                    Signed-off-by: Samuel Pitoiset <<a
                      href="mailto:samuel.pitoiset@gmail.com"
                      target="_blank" moz-do-not-send="true">samuel.pitoiset@gmail.com</a>><br>
                    ---<br>
                     src/amd/common/ac_llvm_build.c | 46
                    +++++++++++++++++++---------------<br>
                     1 file changed, 26 insertions(+), 20 deletions(-)<br>
                    <br>
                    diff --git a/src/amd/common/ac_llvm_build.c
                    b/src/amd/common/ac_llvm_build.c<br>
                    index 8f40ddda0b5..92dd4104592 100644<br>
                    --- a/src/amd/common/ac_llvm_build.c<br>
                    +++ b/src/amd/common/ac_llvm_build.c<br>
                    @@ -1135,6 +1135,7 @@
                    ac_build_llvm8_buffer_store_common(struct
                    ac_llvm_context *ctx,<br>
                                                       LLVMValueRef
                    voffset,<br>
                                                       LLVMValueRef
                    soffset,<br>
                                                       unsigned
                    num_channels,<br>
                    +                                  LLVMTypeRef
                    base_type,<br>
                  </blockquote>
                  <div><br>
                  </div>
                  <div>Can this be called return_channel_type?</div>
                </div>
              </div>
            </blockquote>
            Done locally.<br>
            <blockquote type="cite">
              <div dir="ltr">
                <div class="gmail_quote">
                  <div><br>
                  </div>
                  <div>Thanks,</div>
                  <div>Marek</div>
                  <br>
                </div>
              </div>
            </blockquote>
          </div>
        </blockquote>
      </div>
    </blockquote>
  </body>
</html>