<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<div class="moz-cite-prefix">On 4/22/19 7:19 PM, Marek Olšák wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAAxE2A5KBrAybLPmExnoZaWspwKORKVfRscww2E27DMmw_1ScQ@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div>Is "XXX" in the comment really necessary?</div>
</div>
</blockquote>
No, but I already pushed the series.<br>
<blockquote type="cite"
cite="mid:CAAxE2A5KBrAybLPmExnoZaWspwKORKVfRscww2E27DMmw_1ScQ@mail.gmail.com">
<div dir="ltr">
<div><br>
</div>
<div>Marek<br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Thu, Apr 18, 2019 at 3:20
AM Samuel Pitoiset <<a
href="mailto:samuel.pitoiset@gmail.com"
moz-do-not-send="true">samuel.pitoiset@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">They are buggy with LLVM
8 because they weren't marked as source<br>
of divergence, see r358579.<br>
<br>
Fixes: dd0172e865f ("radv: Use structured intrinsics instead
of indexing workaround for GFX9.")"<br>
Signed-off-by: Samuel Pitoiset <<a
href="mailto:samuel.pitoiset@gmail.com" target="_blank"
moz-do-not-send="true">samuel.pitoiset@gmail.com</a>><br>
---<br>
src/amd/common/ac_nir_to_llvm.c | 5 ++++-<br>
1 file changed, 4 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/amd/common/ac_nir_to_llvm.c
b/src/amd/common/ac_nir_to_llvm.c<br>
index 3890aebc982..fcd75903088 100644<br>
--- a/src/amd/common/ac_nir_to_llvm.c<br>
+++ b/src/amd/common/ac_nir_to_llvm.c<br>
@@ -2634,7 +2634,10 @@ static LLVMValueRef
visit_image_atomic(struct ac_nir_context *ctx,<br>
params[param_count++] =
LLVMBuildExtractElement(ctx->ac.builder, get_src(ctx,
instr->src[1]),<br>
ctx->ac.i32_0, ""); /* vindex */<br>
params[param_count++] = ctx->ac.i32_0; /*
voffset */<br>
- if (HAVE_LLVM >= 0x800) {<br>
+ if (HAVE_LLVM >= 0x900) {<br>
+ /* XXX: The new raw/struct atomic
intrinsics are buggy<br>
+ * with LLVM 8, see r358579.<br>
+ */<br>
params[param_count++] =
ctx->ac.i32_0; /* soffset */<br>
params[param_count++] =
ctx->ac.i32_0; /* slc */<br>
<br>
-- <br>
2.21.0<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org"
target="_blank" moz-do-not-send="true">mesa-dev@lists.freedesktop.org</a><br>
<a
href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev"
rel="noreferrer" target="_blank" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a></blockquote>
</div>
</div>
</blockquote>
</body>
</html>