<div dir="ltr"><div>For the series:</div><div><br></div><div>Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>></div><div><br></div><div>Marek<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 3, 2019 at 7:06 AM Haehnle, Nicolai <<a href="mailto:Nicolai.Haehnle@amd.com">Nicolai.Haehnle@amd.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 03.05.19 12:36, Nicolai Hähnle wrote:<br>
> On 25.04.19 13:18, Nicolai Hähnle wrote:<br>
>> @@ -4618,21 +4648,27 @@ static void si_bind_vertex_elements(struct <br>
>> pipe_context *ctx, void *state)<br>
>>       struct si_vertex_elements *old = sctx->vertex_elements;<br>
>>       struct si_vertex_elements *v = (struct si_vertex_elements*)state;<br>
>>       sctx->vertex_elements = v;<br>
>>       sctx->vertex_buffers_dirty = true;<br>
>>       if (v &&<br>
>>           (!old ||<br>
>>            old->count != v->count ||<br>
>>            old->uses_instance_divisors != v->uses_instance_divisors ||<br>
>> -         v->uses_instance_divisors || /* we don't check which <br>
>> divisors changed */<br>
>> +         /* we don't check which divisors changed */<br>
>> +         v->uses_instance_divisors ||<br>
>> +         /* fix_fetch_{always,opencode,unaligned} and <br>
>> hw_load_is_dword are<br>
>> +          * functions of fix_fetch and the src_offset alignment.<br>
>> +          * If they change and fix_fetch doesn't, it must be due to <br>
>> different<br>
>> +          * src_offset alignment, which is reflected in <br>
>> fix_fetch_opencode. */<br>
>> +         old->fix_fetch_opencode != v->fix_fetch_opencode ||<br>
>>            memcmp(old->fix_fetch, v->fix_fetch, <br>
>> sizeof(v->fix_fetch[0]) * v->count)))<br>
> <br>
> The following condition got dropped in a late cleanup that I was doing:<br>
> <br>
>> (old->vb_alignment_check_mask ^ v->vb_alignment_check_mask) & <br>
>> sctx->vertex_buffer_unaligned ||<br>
<br>
... and also this:<br>
<br>
>            ((v->vb_alignment_check_mask & sctx->vertex_buffer_unaligned) &&<br>
>             memcmp(old->vertex_buffer_index, v->vertex_buffer_index,<br>
>                    sizeof(v->vertex_buffer_index[0]) * v->count)) ||<br>
<br>
Cheers,<br>
Nicolai<br>
<br>
<br>
> <br>
> I've fixed that locally.<br>
> <br>
> Cheers,<br>
> Nicolai<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a></blockquote></div>