<div dir="ltr"><div>Besides my comment on one of the patches, the series is:</div><div><br></div><div>Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>></div><div><br></div><div>Marek<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, May 4, 2019 at 9:39 AM Nicolai Hähnle <<a href="mailto:nhaehnle@gmail.com">nhaehnle@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">From: Nicolai Hähnle <<a href="mailto:nicolai.haehnle@amd.com" target="_blank">nicolai.haehnle@amd.com</a>><br>
<br>
This implies that the memory will always be at address 0, which allows<br>
LLVM to generate slightly better code.<br>
---<br>
src/gallium/drivers/radeonsi/si_shader.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c<br>
index 0cf4d01a36f..91f4c177bd0 100644<br>
--- a/src/gallium/drivers/radeonsi/si_shader.c<br>
+++ b/src/gallium/drivers/radeonsi/si_shader.c<br>
@@ -2201,21 +2201,21 @@ void si_declare_compute_memory(struct si_shader_context *ctx)<br>
<br>
LLVMTypeRef i8p = LLVMPointerType(ctx->i8, AC_ADDR_SPACE_LDS);<br>
LLVMValueRef var;<br>
<br>
assert(!ctx->ac.lds);<br>
<br>
var = LLVMAddGlobalInAddressSpace(ctx->ac.module,<br>
LLVMArrayType(ctx->i8, lds_size),<br>
"compute_lds",<br>
AC_ADDR_SPACE_LDS);<br>
- LLVMSetAlignment(var, 4);<br>
+ LLVMSetAlignment(var, 64 * 1024);<br>
<br>
ctx->ac.lds = LLVMBuildBitCast(ctx->ac.builder, var, i8p, "");<br>
}<br>
<br>
void si_tgsi_declare_compute_memory(struct si_shader_context *ctx,<br>
const struct tgsi_full_declaration *decl)<br>
{<br>
assert(decl->Declaration.MemType == TGSI_MEMORY_TYPE_SHARED);<br>
assert(decl->Range.First == decl->Range.Last);<br>
<br>
-- <br>
2.20.1<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a></blockquote></div>