<div dir="ltr"><div>Ran it through shader-db. No changes. Feel free to stuff that in the commit message somewhere.<br></div><div><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, May 15, 2019 at 12:04 AM Alyssa Rosenzweig <<a href="mailto:alyssa@rosenzweig.io">alyssa@rosenzweig.io</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This line is no longer relevant now that booleans are 1-bit, and in fact<br> causes issues (infinite progress loop between algebraic optimizations<br> and copy prop) with constant vector masks.<br> <br> Signed-off-by: Alyssa Rosenzweig <<a href="mailto:alyssa@rosenzweig.io" target="_blank">alyssa@rosenzweig.io</a>><br> Cc: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com" target="_blank">jason.ekstrand@intel.com</a>><br> ---<br> src/compiler/nir/nir_opt_algebraic.py | 3 ---<br> 1 file changed, 3 deletions(-)<br> <br> diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py<br> index 1c7b3597c1f..89d07aa1261 100644<br> --- a/src/compiler/nir/nir_opt_algebraic.py<br> +++ b/src/compiler/nir/nir_opt_algebraic.py<br> @@ -621,9 +621,6 @@ optimizations = [<br> (('bcsel', True, b, c), b),<br> (('bcsel', False, b, c), c),<br> (('bcsel', a, ('b2f(is_used_once)', 'b@32'), ('b2f', 'c@32')), ('b2f', ('bcsel', a, b, c))),<br> - # The result of this should be hit by constant propagation and, in the<br> - # next round of opt_algebraic, get picked up by one of the above two.<br> - (('bcsel', '#a', b, c), ('bcsel', ('ine', 'a', 0), b, c)),<br> <br> (('bcsel', a, b, b), b),<br> (('fcsel', a, b, b), b),<br> -- <br> 2.20.1<br> <br> _______________________________________________<br> mesa-dev mailing list<br> <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a></blockquote></div>