<div dir="ltr"><div>Yes, this looks like a typo.</div><div><br></div><div>Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>></div><div><br></div><div>Marek<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, May 22, 2019 at 5:10 PM Dave Airlie <<a href="mailto:airlied@gmail.com">airlied@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">ping? nha? mareko maybe?<br>
<br>
Dave.<br>
<br>
On Fri, 17 May 2019 at 12:02, Dave Airlie <<a href="mailto:airlied@gmail.com" target="_blank">airlied@gmail.com</a>> wrote:<br>
><br>
> mesa-19.1.0-rc2/src/amd/common/ac_llvm_build.c:4019: copy_paste_error:<br>
> "result_exclusive" in "ws->result_exclusive" looks like a copy-paste<br>
> error.<br>
><br>
> +       if (ws->enable_inclusive)<br>
> +               ws->result_inclusive = ac_build_alu_op(ctx,<br>
> ws->result_exclusive, ws->src, ws->op);<br>
> +       if (ws->enable_exclusive)<br>
> +               ws->result_exclusive = ac_build_alu_op(ctx,<br>
> ws->result_exclusive, ws->extra, ws->op);<br>
><br>
> Is that right? maybe a comment?<br>
><br>
> Dave.<br>
</blockquote></div>