<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Reviewed-by: Jose Fonseca <jfonseca@vmware.com></div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks.</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Jose</div>
<div>
<div id="appendonsend"></div>
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> sroland@vmware.com <sroland@vmware.com><br>
<b>Sent:</b> Friday, May 24, 2019 02:08<br>
<b>To:</b> Jose Fonseca; mesa-dev@lists.freedesktop.org<br>
<b>Cc:</b> Roland Scheidegger<br>
<b>Subject:</b> [PATCH] gallivm: fix default cbuf info.</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">From: Roland Scheidegger <sroland@vmware.com><br>
<br>
The default null_output really needs to be static, otherwise the values<br>
we'll eventually get later are doubly random (they are not initialized,<br>
and even if they were it's a pointer to a local stack variable).<br>
VMware bug 2349556.<br>
---<br>
src/gallium/auxiliary/gallivm/lp_bld_tgsi_info.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_info.c b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_info.c<br>
index b4e3c2fbc8..9fc9b8c77e 100644<br>
--- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_info.c<br>
+++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_info.c<br>
@@ -608,7 +608,7 @@ finished:<br>
*/<br>
<br>
for (index = 0; index < PIPE_MAX_COLOR_BUFS; ++index) {<br>
- const struct lp_tgsi_channel_info null_output[4];<br>
+ static const struct lp_tgsi_channel_info null_output[4];<br>
info->cbuf[index] = null_output;<br>
}<br>
<br>
-- <br>
2.17.1<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>