<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 4, 2019, 1:29 AM Jan Vesely <<a href="mailto:jan.vesely@rutgers.edu">jan.vesely@rutgers.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, 2019-06-04 at 00:20 -0400, Marek Olšák wrote:<br> > This series will probably conflict with the new linker, which will<br> > also<br> > handle relocations and more:<br> > <a href="https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fseries%2F60255%2F&data=02%7C01%7Cjan.vesely%40cs.rutgers.edu%7C48f1da4abf674754c36208d6e8a421ea%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C636952188985357253&sdata=O6Z%2Ftp6JUpjDgCU%2BvPN0Tp4nlBbhyR6XWzb7uaCNYls%3D&reserved=0" rel="noreferrer noreferrer" target="_blank">https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fseries%2F60255%2F&data=02%7C01%7Cjan.vesely%40cs.rutgers.edu%7C48f1da4abf674754c36208d6e8a421ea%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C636952188985357253&sdata=O6Z%2Ftp6JUpjDgCU%2BvPN0Tp4nlBbhyR6XWzb7uaCNYls%3D&reserved=0</a><br> <br> It sure does. That series does not consider sections as relocation<br> targets, but it's just few lines to patch that in. is there an ETA for<br> the linker series?<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">No ETA but we should push that pretty soon.</div><div dir="auto"><br></div><div dir="auto">Marek</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> Jan<br> <br> > <br> > Marek<br> > <br> > On Mon, Jun 3, 2019 at 10:39 PM Jan Vesely <<a href="mailto:jan.vesely@rutgers.edu" target="_blank" rel="noreferrer">jan.vesely@rutgers.edu</a>> wrote:<br> > <br> > > Cc: <a href="mailto:mesa-stable@lists.freedesktop.org" target="_blank" rel="noreferrer">mesa-stable@lists.freedesktop.org</a><br> > > Signed-off-by: Jan Vesely <<a href="mailto:jan.vesely@rutgers.edu" target="_blank" rel="noreferrer">jan.vesely@rutgers.edu</a>><br> > > ---<br> > > src/amd/common/ac_binary.c | 2 ++<br> > > src/amd/common/ac_binary.h | 2 ++<br> > > 2 files changed, 4 insertions(+)<br> > > <br> > > diff --git a/src/amd/common/ac_binary.c b/src/amd/common/ac_binary.c<br> > > index 8f4755ebe16..18dc72c61f0 100644<br> > > --- a/src/amd/common/ac_binary.c<br> > > +++ b/src/amd/common/ac_binary.c<br> > > @@ -102,6 +102,8 @@ static void parse_relocs(Elf *elf, Elf_Data *relocs,<br> > > Elf_Data *symbols,<br> > > reloc->offset = rel.r_offset;<br> > > strncpy(reloc->name, symbol_name, sizeof(reloc->name)-1);<br> > > reloc->name[sizeof(reloc->name)-1] = 0;<br> > > + reloc->type = GELF_R_TYPE(rel.r_info);<br> > > + reloc->target_type = GELF_ST_TYPE(symbol.st_info);<br> > > }<br> > > }<br> > > <br> > > diff --git a/src/amd/common/ac_binary.h b/src/amd/common/ac_binary.h<br> > > index 735e3932055..7541f19fb8e 100644<br> > > --- a/src/amd/common/ac_binary.h<br> > > +++ b/src/amd/common/ac_binary.h<br> > > @@ -34,6 +34,8 @@ extern "C" {<br> > > struct ac_shader_reloc {<br> > > char name[32];<br> > > uint64_t offset;<br> > > + int type;<br> > > + int target_type;<br> > > };<br> > > <br> > > struct ac_shader_binary {<br> > > --<br> > > 2.21.0<br> > > <br> > > _______________________________________________<br> > > mesa-stable mailing list<br> > > <a href="mailto:mesa-stable@lists.freedesktop.org" target="_blank" rel="noreferrer">mesa-stable@lists.freedesktop.org</a><br> > > <a href="https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-stable&data=02%7C01%7Cjan.vesely%40cs.rutgers.edu%7C48f1da4abf674754c36208d6e8a421ea%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C636952188985357253&sdata=nzz6HTQyMlkHHqFDKOgGb8r9k55YjXtwbO7VQUBCyaU%3D&reserved=0" rel="noreferrer noreferrer" target="_blank">https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-stable&data=02%7C01%7Cjan.vesely%40cs.rutgers.edu%7C48f1da4abf674754c36208d6e8a421ea%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C636952188985357253&sdata=nzz6HTQyMlkHHqFDKOgGb8r9k55YjXtwbO7VQUBCyaU%3D&reserved=0</a><br> <br> -- <br> Jan Vesely <<a href="mailto:jan.vesely@rutgers.edu" target="_blank" rel="noreferrer">jan.vesely@rutgers.edu</a>><br> </blockquote></div></div></div>