<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - can't start GDM when building mesa master branch with LTO"
href="https://bugs.freedesktop.org/show_bug.cgi?id=110884#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - can't start GDM when building mesa master branch with LTO"
href="https://bugs.freedesktop.org/show_bug.cgi?id=110884">bug 110884</a>
from <span class="vcard"><a class="email" href="mailto:thiago@kde.org" title="Thiago Macieira <thiago@kde.org>"> <span class="fn">Thiago Macieira</span></a>
</span></b>
<pre>This patch appears to fix the problem:
>From 49607f0524539cb836065b626bb3d3946061c486 Mon Sep 17 00:00:00 2001
From: Thiago Macieira <<a href="mailto:thiago.macieira@intel.com">thiago.macieira@intel.com</a>>
Date: Mon, 10 Jun 2019 19:13:12 -0700
Subject: [PATCH] Attempt at fixing strict aliasing violation in dequeueing
packets
lp_scene_dequeue() calls util_ringbuffer_dequeue() with a payload that
isn't an array of struct util_packets. When util_ringbuffer_dequeue()
made the direct copy, the compiler discarded because it wasn't writing
the right type.
Signed-off-by: Thiago Macieira <<a href="mailto:thiago.macieira@intel.com">thiago.macieira@intel.com</a>>
---
src/gallium/auxiliary/util/u_ringbuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/util/u_ringbuffer.c
b/src/gallium/auxiliary/util/u_ringbuffer.c
index f6bb910671e..cebb908410c 100644
--- a/src/gallium/auxiliary/util/u_ringbuffer.c
+++ b/src/gallium/auxiliary/util/u_ringbuffer.c
@@ -146,7 +146,7 @@ enum pipe_error util_ringbuffer_dequeue( struct
util_ringbuffer *ring,
/* Copy data from ring:
*/
for (i = 0; i < ring_packet->dwords; i++) {
- packet[i] = ring->buf[ring->tail];
+ memcpy(packet + i, ring->buf + ring->tail, sizeof(*packet));
ring->tail++;
ring->tail &= ring->mask;
}
--
2.22.0</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>