<div dir="auto"><div>Can we fix the title?(inherit)<br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 13, 2019, 1:53 PM Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com">samuel.pitoiset@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Otherwise fast color/depth clears can't work because they depend<br>
on the framebuffer.<br>
<br>
This fixes the following CTS (when the small hint is disabled):<br>
- dEQP-VK.geometry.layered.1d_array.secondary_cmd_buffer<br>
- dEQP-VK.geometry.layered.2d_array.secondary_cmd_buffer<br>
- dEQP-VK.geometry.layered.cube.secondary_cmd_buffer<br>
- dEQP-VK.geometry.layered.cube_array.secondary_cmd_buffer<br>
<br>
Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=110810" rel="noreferrer noreferrer" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=110810</a><br>
Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=107986" rel="noreferrer noreferrer" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=107986</a></blockquote></div></div><div dir="auto"><br></div><div dir="auto">So why is 107986 in here?</div><div dir="auto"><br></div><div dir="auto">Also can we remove 110810? This patch only solves half the issue. (Subpass clears still need the inherited state)</div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Signed-off-by: Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com" target="_blank" rel="noreferrer">samuel.pitoiset@gmail.com</a>><br>
---<br>
 src/amd/vulkan/radv_cmd_buffer.c | 9 +++++++++<br>
 1 file changed, 9 insertions(+)<br>
<br>
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c<br>
index 2fd5f8b7a07..b59d78f1829 100644<br>
--- a/src/amd/vulkan/radv_cmd_buffer.c<br>
+++ b/src/amd/vulkan/radv_cmd_buffer.c<br>
@@ -3680,6 +3680,15 @@ void radv_CmdExecuteCommands(<br>
                if (secondary->sample_positions_needed)<br>
                        primary->sample_positions_needed = true;<br>
<br>
+               if (!secondary->state.framebuffer &&<br>
+                   (primary->state.dirty & RADV_CMD_DIRTY_FRAMEBUFFER)) {<br>
+                       /* Emit the framebuffer state from primary if secondary<br>
+                        * has been recorded without a framebuffer, otherwise<br>
+                        * fast color/depth clears can't work.<br>
+                        */<br>
+                       radv_emit_framebuffer_state(primary);<br>
+               }<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Clear the framebuffer dirty bit?</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+<br>
                primary->device->ws->cs_execute_secondary(primary->cs, secondary->cs);<br>
<br>
<br>
-- <br>
2.22.0<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank" rel="noreferrer">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a></blockquote></div></div></div>