<div dir="auto">R-b</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 13, 2019, 12:40 PM Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com">samuel.pitoiset@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This fixes a segfault when forcing DCC decompressions on compute<br>
because internal meta objects are not created since the on-demand<br>
stuff.<br>
<br>
Signed-off-by: Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com" target="_blank" rel="noreferrer">samuel.pitoiset@gmail.com</a>><br>
---<br>
src/amd/vulkan/radv_meta_fast_clear.c | 8 ++++++++<br>
1 file changed, 8 insertions(+)<br>
<br>
diff --git a/src/amd/vulkan/radv_meta_fast_clear.c b/src/amd/vulkan/radv_meta_fast_clear.c<br>
index 8f97c1a8f15..176f9803b45 100644<br>
--- a/src/amd/vulkan/radv_meta_fast_clear.c<br>
+++ b/src/amd/vulkan/radv_meta_fast_clear.c<br>
@@ -753,6 +753,14 @@ radv_decompress_dcc_compute(struct radv_cmd_buffer *cmd_buffer,<br>
state->flush_bits |= RADV_CMD_FLAG_FLUSH_AND_INV_CB |<br>
RADV_CMD_FLAG_FLUSH_AND_INV_CB_META;<br>
<br>
+ if (!cmd_buffer->device->meta_state.fast_clear_flush.cmask_eliminate_pipeline) {<br>
+ VkResult ret = radv_device_init_meta_fast_clear_flush_state_internal(cmd_buffer->device);<br>
+ if (ret != VK_SUCCESS) {<br>
+ cmd_buffer->record_result = ret;<br>
+ return;<br>
+ }<br>
+ }<br>
+<br>
radv_meta_save(&saved_state, cmd_buffer, RADV_META_SAVE_DESCRIPTORS |<br>
RADV_META_SAVE_COMPUTE_PIPELINE);<br>
<br>
-- <br>
2.22.0<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank" rel="noreferrer">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a></blockquote></div>