<div dir="auto">If you don't wanna see the messages, don't use debugoptimized.<div dir="auto"> </div><div dir="auto">Marek</div></div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue., Jul. 2, 2019, 10:15 Michel Dänzer, <<a href="mailto:michel@daenzer.net">michel@daenzer.net</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 2019-07-02 2:09 p.m., Mathias Fröhlich wrote: > On Tuesday, 2 July 2019 10:25:41 CEST Michel Dänzer wrote: >> On 2019-07-02 3:44 a.m., Dieter Nützel wrote: >>> >>> /opt/mesa> git bisect good >>> b5697c311b6f29dee40b96c48bad3279e3667c1e is the first bad commit >>> commit b5697c311b6f29dee40b96c48bad3279e3667c1e >>> Author: Marek Olšák <<a href="mailto:marek.olsak@amd.com" target="_blank" rel="noreferrer">marek.olsak@amd.com</a>> >>> Date: Thu May 9 21:04:23 2019 -0400 >>> >>> Change a few frequented uses of DEBUG to !NDEBUG >>> >>> debugoptimized builds don't define NDEBUG, but they also don't define >>> DEBUG. We want to enable cheap debug code for these builds. >>> I only chose those occurences that I care about. >>> >>> Reviewed-by: Mathias Fröhlich <<a href="mailto:Mathias.Froehlich@web.de" target="_blank" rel="noreferrer">Mathias.Froehlich@web.de</a>> >>> >>> src/gallium/auxiliary/tgsi/tgsi_ureg.c | 2 +- >>> src/gallium/drivers/radeonsi/si_descriptors.c | 2 +- >>> src/gallium/drivers/radeonsi/si_pipe.h | 2 +- >>> src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 6 +++--- >>> src/gallium/drivers/radeonsi/si_state.c | 4 ++-- >>> src/mesa/main/context.c | 2 +- >>> src/mesa/main/debug.c | 4 ++-- >>> src/mesa/main/errors.c | 6 +++--- >>> src/mesa/main/feedback.c | 2 +- >>> src/mesa/main/formats.c | 2 -- >>> src/mesa/main/imports.c | 4 ++-- >>> src/mesa/main/mtypes.h | 2 +- >>> src/mesa/main/shaderapi.c | 2 +- >>> src/mesa/state_tracker/st_atom_framebuffer.c | 2 +- >>> src/mesa/state_tracker/st_format.c | 2 +- >>> src/mesa/vbo/vbo_exec.h | 2 +- >>> src/mesa/vbo/vbo_exec_api.c | 6 +++--- >>> src/util/slab.c | 4 ++-- >>> 18 files changed, 27 insertions(+), 29 deletions(-) >> >> The changes to src/mesa/main/errors.c mean that Mesa now prints messages >> on GL API usage errors by default when assertions are enabled, whereas >> previously it only did so for debugging builds. This should probably be >> reverted, since these messages can be pretty noisy with some apps. > > My rationale was that it used to print before meson so it should print now again. Before this change, these messages were only printed by default with a debug build, both with meson and autotools. (With autotools, a debug build was required for assertions to be enabled) Now they're printed by default if assertions are enabled, even if debug is disabled. > But I have no strong opinion regarding debug builds being noisy. That's not the issue at hand. -- Earthling Michel Dänzer | <a href="https://www.amd.com" rel="noreferrer noreferrer" target="_blank">https://www.amd.com</a> Libre software enthusiast | Mesa and X developer _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank" rel="noreferrer">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a></blockquote></div>