<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Looks good to me.</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Reviewed-by: Jose Fonseca <jfonseca@vmware.com></div>
<div>
<div id="appendonsend"></div>
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Charmaine Lee <charmainel@vmware.com><br>
<b>Sent:</b> Thursday, August 1, 2019 23:56<br>
<b>To:</b> mesa-dev@lists.freedesktop.org <mesa-dev@lists.freedesktop.org>; Brian Paul <brianp@vmware.com>; Neha Bhende <bhenden@vmware.com>; Roland Scheidegger <sroland@vmware.com>; Jose Fonseca <jfonseca@vmware.com>; airlied@redhat.com <airlied@redhat.com><br>
<b>Cc:</b> Charmaine Lee <charmainel@vmware.com><br>
<b>Subject:</b> [PATCH] gallivm: fix a missing argument to CreateAtomicCmpXchg</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">This patch fixes a missing argument to CreateAtomicCmpXchg for older<br>
version of LLVM.<br>
---<br>
src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 1 +<br>
1 file changed, 1 insertion(+)<br>
<br>
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp<br>
index 79d1029..8205d24 100644<br>
--- a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp<br>
+++ b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp<br>
@@ -831,6 +831,7 @@ LLVMValueRef LLVMBuildAtomicCmpXchg(LLVMBuilderRef B, LLVMValueRef Ptr,<br>
/* LLVM 3.8 doesn't have a second ordering and uses old SynchronizationScope enum */<br>
return llvm::wrap(llvm::unwrap(B)->CreateAtomicCmpXchg(llvm::unwrap(Ptr), llvm::unwrap(Cmp),<br>
llvm::unwrap(New), mapFromLLVMOrdering(SuccessOrdering),<br>
+ mapFromLLVMOrdering(FailureOrdering),<br>
SingleThread ? llvm::SynchronizationScope::SingleThread : llvm::SynchronizationScope::CrossThread));<br>
}<br>
#endif<br>
-- <br>
1.8.5.6<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>