<div dir="ltr"><div dir="ltr">Hi,</div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 13, 2019 at 2:03 PM Tapani Pälli <<a href="mailto:tapani.palli@intel.com">tapani.palli@intel.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi; On 8/13/19 2:43 PM, Mauro Rossi wrote: > Hi Tapani, > > On Sat, Jul 27, 2019 at 2:56 PM Mauro Rossi <<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a> > <mailto:<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>>> wrote: > > On Sat, Jul 27, 2019 at 2:56 PM Mauro Rossi <<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a> > <mailto:<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>>> wrote: > > > > On Thu, Jul 18, 2019 at 1:07 PM Chih-Wei Huang > <<a href="mailto:cwhuang@android-x86.org" target="_blank">cwhuang@android-x86.org</a> <mailto:<a href="mailto:cwhuang@android-x86.org" target="_blank">cwhuang@android-x86.org</a>>> wrote: > > > > > > Mauro Rossi <<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a> > <mailto:<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>>> 於 2019年7月14日週日下午5:17寫道： > > > > > > > > This patch partially reverts 20294dc ("mesa: Enable asm > unconditionally, ...") > > > > > > > > Android makefile build logic needs to disable assembler > optimization > > > > in 32bit builds to avoid text relocations for libglapi.so shared > > > > > > > > Fixes the following build error with Android x86 32bit target: > > > > > > > > [ 0% 4/477] target SharedLib: libglapi > (out/target/product/x86/obj/SHARED_LIBRARIES/libglapi_intermediates/LINKED/libglapi.so) > > > > FAILED: > out/target/product/x86/obj/SHARED_LIBRARIES/libglapi_intermediates/LINKED/libglapi.so > > > > ... > > > > > prebuilts/gcc/linux-x86/x86/x86_64-linux-android-4.9/x86_64-linux-android/bin/ld: > warning: shared library text segment is not shareable > > > > > prebuilts/gcc/linux-x86/x86/x86_64-linux-android-4.9/x86_64-linux-android/bin/ld: > error: treating warnings as errors > > > > clang-6.0: error: linker command failed with exit code 1 (use > -v to see invocation) > > > > > > > > Fixes: 20294dc ("mesa: Enable asm unconditionally, now that > gen_matypes is gone.") > > > > Signed-off-by: Mauro Rossi <<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a> > <mailto:<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>>> > > > > --- > > > > <a href="http://Android.common.mk" rel="noreferrer" target="_blank">Android.common.mk</a> <<a href="http://Android.common.mk" rel="noreferrer" target="_blank">http://Android.common.mk</a>> > | 3 +++ > > > > Android.mk | 7 +++++++ > > > > src/mesa/<a href="http://Android.libmesa_dricore.mk" rel="noreferrer" target="_blank">Android.libmesa_dricore.mk</a> > <<a href="http://Android.libmesa_dricore.mk" rel="noreferrer" target="_blank">http://Android.libmesa_dricore.mk</a>> | 2 ++ > > > > src/mesa/<a href="http://Android.libmesa_st_mesa.mk" rel="noreferrer" target="_blank">Android.libmesa_st_mesa.mk</a> > <<a href="http://Android.libmesa_st_mesa.mk" rel="noreferrer" target="_blank">http://Android.libmesa_st_mesa.mk</a>> | 2 ++ > > > > 4 files changed, 14 insertions(+) > > > > > > > > diff --git a/<a href="http://Android.common.mk" rel="noreferrer" target="_blank">Android.common.mk</a> <<a href="http://Android.common.mk" rel="noreferrer" target="_blank">http://Android.common.mk</a>> > b/<a href="http://Android.common.mk" rel="noreferrer" target="_blank">Android.common.mk</a> <<a href="http://Android.common.mk" rel="noreferrer" target="_blank">http://Android.common.mk</a>> > > > > index 8a1c734353..209654bb75 100644 > > > > --- a/<a href="http://Android.common.mk" rel="noreferrer" target="_blank">Android.common.mk</a> <<a href="http://Android.common.mk" rel="noreferrer" target="_blank">http://Android.common.mk</a>> > > > > +++ b/<a href="http://Android.common.mk" rel="noreferrer" target="_blank">Android.common.mk</a> <<a href="http://Android.common.mk" rel="noreferrer" target="_blank">http://Android.common.mk</a>> > > > > @@ -106,9 +106,12 @@ ifeq ($(shell test > $(PLATFORM_SDK_VERSION) -ge 26 && echo true),true) > > > > LOCAL_CFLAGS += -DHAVE_SYS_SHM_H > > > > endif > > > > > > > > +ifeq ($(strip $(MESA_ENABLE_ASM)),true) > > > > ifeq ($(TARGET_ARCH),x86) > > > > LOCAL_CFLAGS += \ > > > > -DUSE_X86_ASM > > > > + > > > > +endif > > > > endif > > > > ifeq ($(ARCH_ARM_HAVE_NEON),true) > > > > LOCAL_CFLAGS_arm += -DUSE_ARM_ASM > > > > diff --git a/Android.mk b/Android.mk > > > > index 57613eccfc..4a2a003ea3 100644 > > > > --- a/Android.mk > > > > +++ b/Android.mk > > > > @@ -83,6 +83,13 @@ endif > > > > > > > > $(foreach d, $(MESA_BUILD_CLASSIC) $(MESA_BUILD_GALLIUM), > $(eval $(d) := true)) > > > > > > > > +# host and target must be the same arch to generate matypes.h > > > > +ifeq ($(TARGET_ARCH),$(HOST_ARCH)) > > > > +MESA_ENABLE_ASM := true > > > > +else > > > > +MESA_ENABLE_ASM := false > > > > +endif > > > > + > > > > ifneq ($(filter true, $(HAVE_GALLIUM_RADEONSI)),) > > > > MESA_ENABLE_LLVM := true > > > > endif > > > > diff --git a/src/mesa/<a href="http://Android.libmesa_dricore.mk" rel="noreferrer" target="_blank">Android.libmesa_dricore.mk</a> > <<a href="http://Android.libmesa_dricore.mk" rel="noreferrer" target="_blank">http://Android.libmesa_dricore.mk</a>> > b/src/mesa/<a href="http://Android.libmesa_dricore.mk" rel="noreferrer" target="_blank">Android.libmesa_dricore.mk</a> > <<a href="http://Android.libmesa_dricore.mk" rel="noreferrer" target="_blank">http://Android.libmesa_dricore.mk</a>> > > > > index 8eb6aabe83..792117767b 100644 > > > > --- a/src/mesa/<a href="http://Android.libmesa_dricore.mk" rel="noreferrer" target="_blank">Android.libmesa_dricore.mk</a> > <<a href="http://Android.libmesa_dricore.mk" rel="noreferrer" target="_blank">http://Android.libmesa_dricore.mk</a>> > > > > +++ b/src/mesa/<a href="http://Android.libmesa_dricore.mk" rel="noreferrer" target="_blank">Android.libmesa_dricore.mk</a> > <<a href="http://Android.libmesa_dricore.mk" rel="noreferrer" target="_blank">http://Android.libmesa_dricore.mk</a>> > > > > @@ -39,9 +39,11 @@ LOCAL_MODULE_CLASS := STATIC_LIBRARIES > > > > LOCAL_SRC_FILES := \ > > > > $(MESA_FILES) > > > > > > > > +ifeq ($(strip $(MESA_ENABLE_ASM)),true) > > > > ifeq ($(TARGET_ARCH),x86) > > > > LOCAL_SRC_FILES += $(X86_FILES) > > > > endif # x86 > > > > +endif # MESA_ENABLE_ASM > > > > > > > > ifeq ($(ARCH_X86_HAVE_SSE4_1),true) > > > > LOCAL_WHOLE_STATIC_LIBRARIES := \ > > > > diff --git a/src/mesa/<a href="http://Android.libmesa_st_mesa.mk" rel="noreferrer" target="_blank">Android.libmesa_st_mesa.mk</a> > <<a href="http://Android.libmesa_st_mesa.mk" rel="noreferrer" target="_blank">http://Android.libmesa_st_mesa.mk</a>> > b/src/mesa/<a href="http://Android.libmesa_st_mesa.mk" rel="noreferrer" target="_blank">Android.libmesa_st_mesa.mk</a> > <<a href="http://Android.libmesa_st_mesa.mk" rel="noreferrer" target="_blank">http://Android.libmesa_st_mesa.mk</a>> > > > > index 16153a3c5b..ddfd03059c 100644 > > > > --- a/src/mesa/<a href="http://Android.libmesa_st_mesa.mk" rel="noreferrer" target="_blank">Android.libmesa_st_mesa.mk</a> > <<a href="http://Android.libmesa_st_mesa.mk" rel="noreferrer" target="_blank">http://Android.libmesa_st_mesa.mk</a>> > > > > +++ b/src/mesa/<a href="http://Android.libmesa_st_mesa.mk" rel="noreferrer" target="_blank">Android.libmesa_st_mesa.mk</a> > <<a href="http://Android.libmesa_st_mesa.mk" rel="noreferrer" target="_blank">http://Android.libmesa_st_mesa.mk</a>> > > > > @@ -42,9 +42,11 @@ LOCAL_GENERATED_SOURCES := \ > > > > $(MESA_GEN_GLSL_H) \ > > > > $(MESA_GEN_NIR_H) > > > > > > > > +ifeq ($(strip $(MESA_ENABLE_ASM)),true) > > > > ifeq ($(TARGET_ARCH),x86) > > > > LOCAL_SRC_FILES += $(X86_FILES) > > > > endif # x86 > > > > +endif # MESA_ENABLE_ASM > > > > > > > > ifeq ($(ARCH_X86_HAVE_SSE4_1),true) > > > > LOCAL_WHOLE_STATIC_LIBRARIES := \ > > > > -- > > > > > > Looks good to me. > > > > > > Review-by: Chih-Wei Huang <<a href="mailto:cwhuang@linux.org.tw" target="_blank">cwhuang@linux.org.tw</a> > <mailto:<a href="mailto:cwhuang@linux.org.tw" target="_blank">cwhuang@linux.org.tw</a>>> > > > > Added Tapani who should one of the users of 32bit mesa, > > please provide feedback to proceed. > > Mauro > > Tapani added now > M. > > > did you had the chance to have a look > and provide Reviewed-by ? > Sorry I've managed to miss this one. I'm not hitting any problems after mentioned changes though. Does this happen only if you compile on a 32bit machine? I'm compiling both 64bit and 32bit but on a 64bit machine. // Tapani </blockquote><div> </div><div>It happens when compiling on a 64 bit build machine, </div><div>the assembler parts of mesa have text relocation when mesa libglapi 32bit target is compiled.</div><div> </div><div>How do you avoid the linker error?</div><div>Mauro</div><div> </div></div></div>