<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Gallium: removal of the manual defining of PIPE_FORMAT values breaks virgl"
href="https://bugs.freedesktop.org/show_bug.cgi?id=111454#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Gallium: removal of the manual defining of PIPE_FORMAT values breaks virgl"
href="https://bugs.freedesktop.org/show_bug.cgi?id=111454">bug 111454</a>
from <span class="vcard"><a class="email" href="mailto:robclark@freedesktop.org" title="Rob Clark <robclark@freedesktop.org>"> <span class="fn">Rob Clark</span></a>
</span></b>
<pre>(In reply to Ilia Mirkin from <a href="show_bug.cgi?id=111454#c6">comment #6</a>)
<span class="quote">> (In reply to Rob Clark from <a href="show_bug.cgi?id=111454#c5">comment #5</a>)
> > (In reply to Ilia Mirkin from <a href="show_bug.cgi?id=111454#c1">comment #1</a>)
> > > IMO that should just be backed out. PIPE_FORMAT enum values are used in TGSI
> > > code streams.
> >
> > I think the eventual goal is to unify PIPE_FORMAT_* and MESA_FORMAT_*, so I
> > guess some further shuffling could happen.. do formats encoded in TGSI ever
> > constitute some ABI?
>
> You can argue it either way. Virgl uses (used?) this, presumably svga does
> too. The format is encoded in the TGSI ops for image declarations, and
> perhaps in the ops themselves too (due to bindless).
>
> Whether TGSI forms a more permanent ABI or not ... up to us. I see it as a
> strong point of TGSI that it has this fairly stable well-defined wire
> format, but I also don't have the energy to fight it out.</span >
looks like svga does not handle images (yet?).. but it does some amount of
translating the tgsi, so I guess it could remap encoded formats to some stable
over-the-wire format.
But virgl does, and seems to pass the tgsi straight thru. Which makes me
suspect it is still broken for shaders that use images :-/</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>