<div dir="ltr"><div dir="ltr">On Sat, 21 Sep 2019 at 04:27, Karol Herbst <<a href="mailto:kherbst@redhat.com">kherbst@redhat.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Signed-off-by: Karol Herbst <<a href="mailto:kherbst@redhat.com" target="_blank">kherbst@redhat.com</a>><br></blockquote><div><br></div><div>Reviewed-by: Rhys Kidd <<a href="mailto:rhyskidd@gmail.com">rhyskidd@gmail.com</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
src/gallium/drivers/nouveau/codegen/nv50_ir.cpp | 4 +---<br>
src/gallium/drivers/nouveau/codegen/nv50_ir.h | 2 +-<br>
src/gallium/drivers/nouveau/codegen/nv50_ir_target.cpp | 2 +-<br>
3 files changed, 3 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp<br>
index a181a13a3b1..45ee95bb103 100644<br>
--- a/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp<br>
+++ b/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp<br>
@@ -903,10 +903,8 @@ Instruction::isCommutationLegal(const Instruction *i) const<br>
}<br>
<br>
TexInstruction::TexInstruction(Function *fn, operation op)<br>
- : Instruction(fn, op, TYPE_F32)<br>
+ : Instruction(fn, op, TYPE_F32), tex()<br>
{<br>
- memset(&tex, 0, sizeof(tex));<br>
-<br>
tex.rIndirectSrc = -1;<br>
tex.sIndirectSrc = -1;<br>
<br>
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir.h b/src/gallium/drivers/nouveau/codegen/nv50_ir.h<br>
index b19751ab372..5163e1a7ec2 100644<br>
--- a/src/gallium/drivers/nouveau/codegen/nv50_ir.h<br>
+++ b/src/gallium/drivers/nouveau/codegen/nv50_ir.h<br>
@@ -957,7 +957,7 @@ public:<br>
class Target<br>
{<br>
public:<br>
- Target(TexTarget targ = TEX_TARGET_2D) : target(targ) { }<br>
+ Target(TexTarget targ = TEX_TARGET_1D) : target(targ) { }<br>
<br>
const char *getName() const { return descTable[target].name; }<br>
unsigned int getArgCount() const { return descTable[target].argc; }<br>
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_target.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_target.cpp<br>
index 5c6d0570ae2..609e7b89290 100644<br>
--- a/src/gallium/drivers/nouveau/codegen/nv50_ir_target.cpp<br>
+++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_target.cpp<br>
@@ -455,7 +455,7 @@ CodeEmitter::addInterp(int ipa, int reg, FixupApply apply)<br>
if (!fixupInfo)<br>
return false;<br>
if (n == 0)<br>
- memset(fixupInfo, 0, sizeof(FixupInfo));<br>
+ fixupInfo->count = 0;<br>
}<br>
++fixupInfo->count;<br>
<br>
-- <br>
2.21.0<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a></blockquote></div></div>