<html><head></head><body>This is discussed in the merge request thread. Zink currently only support vertex and fragment shaders, so it's the only place this can occur. If someone wants to enable this for drivers that supports geometry or tesselation shaders, they would need to extend this code first. Unless I beat them to it, of course. I don't want to implement this blindly, which is why I left this out for now. <div class="gmail_quote">On October 17, 2019 5:09:36 PM GMT+02:00, Ilia Mirkin <imirkin@alum.mit.edu> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <pre class="k9mail">Hey Erik, Just saw your change <a href="https://cgit.freedesktop.org/mesa/mesa/commit/?id=3298aedd6e9f12cefd5aa7414eeebf69ce7538d1">https://cgit.freedesktop.org/mesa/mesa/commit/?id=3298aedd6e9f12cefd5aa7414eeebf69ce7538d1</a> . It looks like you assume that the UCPs will apply in the vertex stage, but given that we support GL compat profiles for GL 4.0+ in st/mesa, the UCPs actually apply to the same stage that clip distances are processed in -- might be TES or GS, depending on the pipeline. Perhaps there's some reason why this works anyways that I'm not seeing... Cheers, -ilia </pre></blockquote></div> -- Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>