<div dir="ltr">Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Nov 11, 2019 at 5:45 PM Brian Paul <<a href="mailto:brianp@vmware.com">brianp@vmware.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">---<br>
src/compiler/nir/nir_builder.h | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h<br>
index de00fe7..aed4759 100644<br>
--- a/src/compiler/nir/nir_builder.h<br>
+++ b/src/compiler/nir/nir_builder.h<br>
@@ -782,7 +782,7 @@ nir_extract_bits(nir_builder *b, nir_ssa_def **srcs, unsigned num_srcs,<br>
for (unsigned i = 0; i < num_srcs; i++)<br>
common_bit_size = MIN2(common_bit_size, srcs[i]->bit_size);<br>
if (first_bit > 0)<br>
- common_bit_size = MIN2(common_bit_size, (1 << (ffs(first_bit) - 1)));<br>
+ common_bit_size = MIN2(common_bit_size, (1u << (ffs(first_bit) - 1)));<br>
<br>
/* We don't want to have to deal with 1-bit values */<br>
assert(common_bit_size >= 8);<br>
@@ -800,7 +800,7 @@ nir_extract_bits(nir_builder *b, nir_ssa_def **srcs, unsigned num_srcs,<br>
const unsigned bit = first_bit + (i * common_bit_size);<br>
while (bit >= src_end_bit) {<br>
src_idx++;<br>
- assert(src_idx < num_srcs);<br>
+ assert(src_idx < (int) num_srcs);<br>
src_start_bit = src_end_bit;<br>
src_end_bit += srcs[src_idx]->bit_size *<br>
srcs[src_idx]->num_components;<br>
-- <br>
1.8.5.6<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a></blockquote></div>