<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div>
<div id="appendonsend" style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
</div>
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Reviewed-by: Jose Fonseca <jfonseca@vmware.com></div>
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> sroland@vmware.com <sroland@vmware.com><br>
<b>Sent:</b> Monday, December 9, 2019 17:49<br>
<b>To:</b> Jose Fonseca <jfonseca@vmware.com>; jason@jlekstrand.net <jason@jlekstrand.net>; mesa-dev@lists.freedesktop.org <mesa-dev@lists.freedesktop.org><br>
<b>Cc:</b> Roland Scheidegger <sroland@vmware.com><br>
<b>Subject:</b> [PATCH] util/atomic: Fix p_atomic_add for unlocked and msvc paths</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">From: Roland Scheidegger <sroland@vmware.com><br>
<br>
Braces mismatch (flagged by CI, untested).<br>
<br>
Fixes: 385d13f26d2 "util/atomic: Add a _return variant of p_atomic_add"<br>
---<br>
src/util/u_atomic.h | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/util/u_atomic.h b/src/util/u_atomic.h<br>
index 9cbc6dd1eaa..1ad87c8feb1 100644<br>
--- a/src/util/u_atomic.h<br>
+++ b/src/util/u_atomic.h<br>
@@ -89,7 +89,7 @@<br>
#define p_atomic_dec_zero(_v) (p_atomic_dec_return(_v) == 0)<br>
#define p_atomic_inc(_v) ((void) p_atomic_inc_return(_v))<br>
#define p_atomic_dec(_v) ((void) p_atomic_dec_return(_v))<br>
-#define p_atomic_add(_v, _i) ((void) p_atomic_add_return((_v), (_i))<br>
+#define p_atomic_add(_v, _i) ((void) p_atomic_add_return((_v), (_i)))<br>
#define p_atomic_inc_return(_v) (++(*(_v)))<br>
#define p_atomic_dec_return(_v) (--(*(_v)))<br>
#define p_atomic_add_return(_v, _i) (*(_v) = *(_v) + (_i))<br>
@@ -146,7 +146,7 @@<br>
(assert(!"should not get here"), 0))<br>
<br>
#define p_atomic_add(_v, _i) \<br>
- ((void) p_atomic_add_return((_v), (_i))<br>
+ ((void) p_atomic_add_return((_v), (_i)))<br>
<br>
#define p_atomic_add_return(_v, _i) (\<br>
sizeof *(_v) == sizeof(char) ? _InterlockedExchangeAdd8 ((char *) (_v), (_i)) : \<br>
-- <br>
2.17.1<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>