<div dir="ltr">Thank you, Marek.<div><br></div><div>After small additional fixes and rebase up of your branch - bptc rgb_float also works. </div><div><br></div><div>I have updated my merge request.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Sep 22, 2020 at 7:47 PM Marek Olšák <<a href="mailto:maraeo@gmail.com">maraeo@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>bptc-float-modes is fixed by:</div><div><a href="https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6774" target="_blank">https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6774</a></div><div><br></div><div>Marek<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Sep 22, 2020 at 4:33 AM Denis Pauk <<a href="mailto:pauk.denis@gmail.com" target="_blank">pauk.denis@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi Dave,<div><br></div><div>Could you please check <a href="https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6809/diffs" target="_blank">https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6809/diffs</a> ? <br><br>It contains possible fixes for bptc rgba unorm. Bug is related to incorrect reuse current bit_offet reuse between iterations. </div><div><br></div><div>Decompress rgb_float has left without fixes for now.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, May 23, 2020 at 12:47 PM Denis Pauk <<a href="mailto:pauk.denis@gmail.com" target="_blank">pauk.denis@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi Dave,<br><br>I had tested code before only with bptc-modes and bptc-float-modes from piglit. It was free time project, so no real tests.<br><div><br></div><div>Code had reused implementation from intel classic driver if i correctly remember. </div><div><br></div><div>Maybe something wrong with pixel type conversion. I will check.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, May 10, 2020 at 10:26 AM Dave Airlie <<a href="mailto:airlied@gmail.com" target="_blank">airlied@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, 27 Jun 2018 at 06:36, Denis Pauk <<a href="mailto:pauk.denis@gmail.com" target="_blank">pauk.denis@gmail.com</a>> wrote:<br> ><br> > Reuse code shared with mesa/main/texcompress_bptc.<br> ><br> > v2: Use block decompress function<br> > v3: Include static bptc code from texcompress_bptc_tmp.h<br> > Suggested-by: Marek Olšák <<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a>><br> ><br> > Signed-off-by: Denis Pauk <<a href="mailto:pauk.denis@gmail.com" target="_blank">pauk.denis@gmail.com</a>><br> > CC: Nicolai Hähnle <<a href="mailto:nicolai.haehnle@amd.com" target="_blank">nicolai.haehnle@amd.com</a>><br> > CC: Marek Olšák <<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a>><br> > CC: Gert Wollny <<a href="mailto:gw.fossdev@gmail.com" target="_blank">gw.fossdev@gmail.com</a>><br> > ---<br> <br> Hi Denis,<br> <br> not sure you are still around or interested in this code, but I've<br> recently run Vulkan CTS over it and it fails some bc7 tests.<br> <br> It also fails a piglit test that I'm not sure is related or not yet.<br> <br> It only seems to be a corner case failure, like 6 or 7 pixels in the<br> CTS cases, but I'm wondering if you have any insight or memory of<br> where it might diverge.<br> <br> Dave.<br> </blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr">Best regards,<br> Denis.</div> </blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr">Best regards,<br> Denis.</div> _______________________________________________<br> mesa-dev mailing list<br> <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br> </blockquote></div> </blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature">Best regards,<br> Denis.</div>