[Mesa-maintainers] [Mesa-dev] [PATCH 06/28] configure: rename --with-{egl-, }platforms

Igor Gnatenko ignatenko at redhat.com
Tue Dec 13 13:34:20 UTC 2016


On Tue, Dec 13, 2016 at 2:29 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 13 December 2016 at 11:08, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
>> On Thursday, 2016-12-08 19:21:46 +0000, Emil Velikov wrote:
>>> From: Emil Velikov <emil.velikov at collabora.com>
>>>
>>> Since day 1, Vulkan has depended on --with-egl-platforms to select the
>>> platforms build.
>>>
>>> With earlier commits, we've attributed for that internally by renaming
>>> the [internal] conditionals in our build. At the same time having the
>>> --enable-egl and --with-egl-platforms dependency for Vulkan makes no
>>> sense.
>>>
>>> Since where' on the bridge we want to make the conditional generic, thus
>>> others (such as the gallium VL targets) can honour the respective
>>> platforms.
>>>
>>> Cc: mesa-maintainers at lists.freedesktop.org
>>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>>> ---
>>> Should we keep the old configure and error out when anyone provides a
>>> non-default value ? This way they'll have direct feedback how to move
>>> forward. Otherwise they'll likely miss the warning message.
>>
>> Yes, I think we should do this for at least a release or two :)
> I think you're right. It's a bit silly for me to expect that everyone
> will pick up the change straight away.
I will ;)
>
> -Emil
> _______________________________________________
> Mesa-maintainers mailing list
> Mesa-maintainers at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-maintainers



-- 
-Igor Gnatenko


More information about the Mesa-maintainers mailing list