[Mesa-maintainers] Downstream Mesa patches and quirks

[Emil Velikov]

Hi Stefan,

On 20 February 2018 at 11:47, Stefan Dirsch <sndirsch at suse.de> wrote:
> On Mon, Feb 12, 2018 at 05:59:21PM +0000, Emil Velikov wrote:
>> A humble reminder to forward any outstanding patches or hacks needed
>> to get your Mesa packages building.
>> I would kindly urge you to do so, even if your previous attempt did
>> not fare well or you the patch seems not applicable upstream.
>
> I fully agree and support this!
>

Thank you, glad to hear.

>> openSuse
>>  - multiple "never to be upstreamed" patches, shipping exact same
>> binaries 4 times (split xvmc/vdpau/etc)
>
> Sorry for not responding earlier. I have been busy. :-(
>
> - n_Define-GLAPIVAR-separate-from-GLAPI.patch:
>   Add separate definition GLAPIVAR as GLAPI
>   doesn't have the an 'extern' for some compiler
>   versions. This is needed for GLw (bsc#970725).
>  https://build.opensuse.org/package/view_file/X11:XOrg/Mesa/n_Define-GLAPIVAR-separate-from-GLAPI.patch?expand=1
>  https://bugzilla.suse.com/show_bug.cgi?id=970725
>
>  I'm afraid we still need this for ancient 3rd party GLw programs. :-( Egbert?
>
Bug report is not publicly accessible.

There are zero instances of GLAPIVAR on my setup, plus the headers
with the Nvidia driver do not have it either.
Hence I would suggest adding the hack in the GLw header(s).

> - n_Disable-AMDGPU-GFX9-Vega-on-LLVM-lessthan-6.0.0.patch
>   * Disable AMDGPU GFX9/Vega with LLVM < 6.0.0.
>     While it is supported since LLVM 5.0.0, it was not working
>     correctly (bnc#1075901). Since we do not have the resources to
>     determine which fixes should be backported and LLVM 6 will be
>     released relatively soon, disable the support until then. Users
>     with the card will have working desktop using software
>     rendering just like they did with LLVM 4.
>  https://build.opensuse.org/package/view_file/X11:XOrg/Mesa/n_Disable-AMDGPU-GFX9-Vega-on-LLVM-lessthan-6.0.0.patch?expand=1
>  https://bugzilla.suse.com/show_bug.cgi?id=1075901
>
>  Not sure, whether this change would be appreciated upstream in git. Michal?
>
Simple steps:
 - fd.o report already mentions LLVM patches needed
 - update LLVM package adding ^^, check with user that things works as expected

> - n_VDPAU-XVMC-libs-Replace-hardlinks-with-copies.patch
>   * Since these are packaged separately in (open)SUSE anyway, one can use
>   * copies as well. This makes debug packages possible again. (bnc #962609)
>  https://build.opensuse.org/package/view_file/X11:XOrg/Mesa/n_VDPAU-XVMC-libs-Replace-hardlinks-with-copies.patch?expand=1
>  https://bugzilla.suse.com/show_bug.cgi?id=962609
>
>  I'm not aware of a different fix, when splitting vdpau/xvmc to
>  subpackages. :-(
>
Just ship a single mesa-vdpau/etc package? The extra modularity does
not bring you anything.

There are a few patches:

- u_mesa-python3-only.patch
The shebang line should not be needed, looks fine otherwise.

 - misc Mesa 8.0 patches
Originally from Redhat/Fedora - yet they no longer carry them. Drop as
well or upstream?

 - u_Fix-crash-in-swrast-when-setting-a-texture-for-a-pix.patch
Another 8.0 patch - no bugreport or crashlog. Update commit
message+send or drop?

 - u_add_llvm_codegen_dependencies.patch
Looks ok - need commit message+upstream


Last but not least - some .spec nits:
 - imake - gone for about a decade now.
 - libudev - not required since Mesa 13.0.0
 - openssl - not required since Mesa 17.0.0
 - autotools (autoconf, automake, libtool) - not needed when using
release tarballs
 - third party (bison, flex, python*) - same as above
 - mesa-nouveau3d - work with upstream about the threading issue,
don't just remove it
I'll send a patch that might help later on today
 - ncurses-devel - not used by Mesa, assuming LLVM thing - document
 - run ldconfig for backend (ICD) drivers is wrong - dri, nine, xvmc,
vdpau, va, omx, opencl, and vulkan
dri, nine and omx are fine, the remainder need fixing

Might worth doing a casual cross check with the Fedora .spec file.
They have addressed most of the issues already.

HTH
Emil