[Mesa-stable] [PATCH 9.1] i965: Don't print a fatal-looking message if intelCreateContext fails.

Andreas Boll andreas.boll.dev at gmail.com
Fri Aug 2 06:53:36 PDT 2013


From: Kenneth Graunke <kenneth at whitecape.org>

With the old context creation mechanism, an application asked the GL to
give it a context.  Failing to produce a context was a fatal error.

Now, with GLX_ARB_create_context, the application can request a specific
version.  If it's higher than the maximum version we support, context
creation will fail.  But this is a normal error that applications
recover from.

In particular, the new glxinfo tries to create OpenGL 4.3, 4.2, 4.1,
4.0, 3.3, and 3.2 contexts before finally succeeding at creating a 3.1
context.  This led to it printing the following message 6 times:
"brwCreateContext: failed to init intel context"

There's no need to alarm users (and developers) with such a message.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Eric Anholt <eric at anholt.net>
(cherry picked from commit 2dd22130cd708bad4d6ae4acb706394b1dd6ecd9)
---

Please cherry-pick this commit.
It removes a harmless message which appears with the new glxinfo.
arekm reported this on irc.
He noticed the message "brwCreateContext: failed to init intel context".
For more information see [1]

[1] https://bugs.freedesktop.org/show_bug.cgi?id=61554#c11

 src/mesa/drivers/dri/i965/brw_context.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c
index 0b69b53..5cbbc7f 100644
--- a/src/mesa/drivers/dri/i965/brw_context.c
+++ b/src/mesa/drivers/dri/i965/brw_context.c
@@ -135,7 +135,6 @@ brwCreateContext(int api,
                           mesaVis, driContextPriv,
 			  sharedContextPrivate, &functions,
 			  error)) {
-      printf("%s: failed to init intel context\n", __FUNCTION__);
       ralloc_free(brw);
       return false;
    }
-- 
1.7.10.4



More information about the mesa-stable mailing list