[Mesa-stable] [PATCH] glsl: Disallow uniform block layout qualifiers on non-uniform block vars.

Ian Romanick idr at freedesktop.org
Mon Aug 26 17:29:59 PDT 2013


On 08/26/2013 04:49 PM, Matt Turner wrote:
> On Mon, Aug 26, 2013 at 4:35 PM, Ian Romanick <idr at freedesktop.org> wrote:
>>> I think this will allow things like:
>>
>> struct foo {
>>      layout(row_major) mat4 bar;
>> };
>>
>> Yeah?
>
> Don't think so:
>
> error: syntax error, unexpected LAYOUT_TOK

Right... because the grammar doesn't allow it.

Assuming it fixes the broken cases (and doesn't regress anything in a 
full piglit / gles3conform run),

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>



More information about the mesa-stable mailing list