[Mesa-stable] [Mesa-dev] [PATCH v2 2/5] meta: fix meta clear of layered framebuffers

[Eric Anholt]

Eric Anholt <eric at anholt.net> writes:

> Paul Berry <stereotype441 at gmail.com> writes:
>
>> From section 4.4.7 (Layered Framebuffers) of the GLSL 3.2 spec:
>>
>>     When the Clear or ClearBuffer* commands are used to clear a
>>     layered framebuffer attachment, all layers of the attachment are
>>     cleared.
>>
>> This patch fixes meta clears to properly clear all layers of a layered
>> framebuffer attachment.  We accomplish this by adding a geometry
>> shader to the meta clear program which sets gl_Layer to a uniform
>> value.  When clearing a layered framebuffer, we execute in a loop,
>> setting the uniform to point to each layer in turn.
>
> I don't think we should be running a gs in the !NumLayers case.  The
> other patches are:
>
> Reviewed-by: Eric Anholt <eric at anholt.net>

Paul reminded that thanks to the simd16 repdata clear, we're basically
never calling glsl clear on gen6+, and we only enable GS on gen7+.

As such, I'm not really concerned about the performance any more, and by
the time anyone else can care about it we should have ARB_sso, at which
point optionally slotting in a GS to do this work on a layered FB is
easy.  I think.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-stable/attachments/20131121/0d659eb0/attachment.pgp>