[Mesa-stable] [PATCH 2/5] meta: fix meta clear of layered framebuffers

Paul Berry stereotype441 at gmail.com
Fri Nov 22 08:33:25 PST 2013


On 19 November 2013 20:47, Paul Berry <stereotype441 at gmail.com> wrote:

> From section 4.4.7 (Layered Framebuffers) of the GLSL 3.2 spec:
>
>     When the Clear or ClearBuffer* commands are used to clear a
>     layered framebuffer attachment, all layers of the attachment are
>     cleared.
>
> This patch fixes meta clears to properly clear all layers of a layered
> framebuffer attachment.  We accomplish this by adding a geometry
> shader to the meta clear program which sets gl_Layer to a uniform
> value.  When clearing a layered framebuffer, we execute in a loop,
> setting the uniform to point to each layer in turn.
>
> Cc: "10.0" <mesa-stable at lists.freedesktop.org>
>

Note: this patch seems to worsen
https://bugs.freedesktop.org/show_bug.cgi?id=71870 (causes it to crash
instead of producing bad rendering), so we shouldn't cherry-pick it to 10.0
until we've fixed the crash.

Provided that additional problems aren't discovered, the remainder of the
series should still be safe to cherry-pick to 10.0.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-stable/attachments/20131122/2495d2fc/attachment.html>


More information about the mesa-stable mailing list