[Mesa-stable] [Mesa-dev] [PATCH 1/3] i965: Don't forget the cube map padding on gen5+.

[Eric Anholt]

Kenneth Graunke <kenneth at whitecape.org> writes:

> On 10/08/2013 10:36 AM, Eric Anholt wrote:
>> We had a fixup for gen4's 3d-layout cubemaps (which, iirc, we'd
>> experimentally found to be necessary!), but while the spec still requires
>> it on gen5, we'd been missing it in the array-layout cubemaps.
>
> Ah, I see it now:
>
> From the Sandybridge PRM, Volume 1, Part 1, Section 7.19...OR...the
> Ivybridge PRM, Volume 1, Part 1, Section 6.19 (Surface Padding
> Requirements):
>
> "For cube surfaces, an additional two rows of padding are required at
> the bottom of the surface.  This must be ensured regardless of whether
> the surface is stored tiled or linear.  This is due to the potential
> rotation of cache line orientation from memory to cache."
>
> So it sounds like this is indeed necessary on all platforms.  Unless
> they just forgot to remove this text from the docs.  Have you observed
> it to fix anything?

No, but it's hard to trigger -- you need your cube map to be large,
unaligned in the y direction, and to land at the very end of the address
space.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-stable/attachments/20131008/ad9be05f/attachment.pgp>