[Mesa-stable] [Mesa-dev] [PATCH 7/8] mesa: fix assertion in _mesa_drawbuffers()
Ian Romanick
idr at freedesktop.org
Fri Aug 8 14:54:27 PDT 2014
Pavel,
Does this patch fix the problem you were trying to solve?
On 08/08/2014 02:20 PM, Brian Paul wrote:
> Fixes failed assertion when _mesa_update_draw_buffers() was called
> with GL_DRAW_BUFFER == GL_FRONT_AND_BACK. The piglit gl30basic hit
> this.
>
> Cc: "10.2" <mesa-stable at lists.freedesktop.org>
> ---
> src/mesa/main/buffers.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c
> index b13a7af..6b4fac9 100644
> --- a/src/mesa/main/buffers.c
> +++ b/src/mesa/main/buffers.c
> @@ -494,10 +494,11 @@ _mesa_drawbuffers(struct gl_context *ctx, GLuint n, const GLenum *buffers,
> }
>
> /*
> - * If n==1, destMask[0] may have up to four bits set.
> + * destMask[0] may have up to four bits set
> + * (ex: glDrawBuffer(GL_FRONT_AND_BACK)).
> * Otherwise, destMask[x] can only have one bit set.
> */
> - if (n == 1) {
> + if (_mesa_bitcount(destMask[0]) > 1) {
> GLuint count = 0, destMask0 = destMask[0];
> while (destMask0) {
> GLint bufIndex = ffs(destMask0) - 1;
>
More information about the mesa-stable
mailing list