[Mesa-stable] [Mesa-dev] [PATCH 01/13] glsl_to_tgsi: Constify mesa_sysval_to_semantic

Ian Romanick idr at freedesktop.org
Tue Aug 26 15:27:12 PDT 2014


On 08/26/2014 02:56 PM, Emil Velikov wrote:
> On 21/06/14 02:00, Ian Romanick wrote:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>>
> Hello Ian,
> 
> Looking at this series and it appears that only patches 1-4 (inclusive) made
> it in master. Has the rest of it been super-seeded by other patches or did it
> slip through the cracks ?
> 
> Imho most (all?) of the series does not appear like it is suitable for stable.
> Feel free to let me know if you feel otherwise.

We're working out some kinks with the final approach.  Once it's ready
(hopefully this week), I'll send a pull request from a branch.  Right
now gl_VertexID is quite severly broken in some cases, so it will be
very important for this to at least land in 10.3.

Too much travel (and being out sick) over the last month has
significantly delayed this. :(

> -Emil
> 
>> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
>> Cc: Ilia Mirkin <imirkin at alum.mit.edu>
>> Cc: Marek Olšák <marek.olsak at amd.com>
>> Cc: Roland Scheidegger <sroland at vmware.com>
>> Cc: "10.2" <mesa-stable at lists.freedesktop.org>
>> ---
>>  src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
>> index cac1e0f..109291d 100644
>> --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
>> +++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
>> @@ -4235,7 +4235,7 @@ struct st_translate {
>>  };
>>  
>>  /** Map Mesa's SYSTEM_VALUE_x to TGSI_SEMANTIC_x */
>> -static unsigned mesa_sysval_to_semantic[SYSTEM_VALUE_MAX] = {
>> +static const unsigned mesa_sysval_to_semantic[SYSTEM_VALUE_MAX] = {
>>     TGSI_SEMANTIC_FACE,
>>     TGSI_SEMANTIC_VERTEXID,
>>     TGSI_SEMANTIC_INSTANCEID,
>>



More information about the mesa-stable mailing list