[Mesa-stable] [Review Request (main branch)] st/wgl: add WINAPI qualifiers on wgl function typedefs

[Jose Fonseca]

Good find.

I'm surprised this only caused problems on release builds. I'd expect that not using the stdcall convention would corrupt the stack for all build types.

Jose

________________________________________
From: mks-hackers-bounces at vmware.com <mks-hackers-bounces at vmware.com> on behalf of Brian Paul <brianp at vmware.com>
Sent: 03 October 2014 16:59
To: mks-hackers at vmware.com
Cc: 10.3
Subject: [Review Request (main branch)] st/wgl: add WINAPI qualifiers on wgl    function typedefs

Fixes a release build segfault when wglCreateContextAttribsARB()
calls the wglCreateContext() function.

Cc: "10.3" <mesa-stable at lists.freedesktop.org>
---
 src/gallium/state_trackers/wgl/stw_ext_context.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/state_trackers/wgl/stw_ext_context.c b/src/gallium/state_trackers/wgl/stw_ext_context.c
index ac0077b..cfe4e8a 100644
--- a/src/gallium/state_trackers/wgl/stw_ext_context.c
+++ b/src/gallium/state_trackers/wgl/stw_ext_context.c
@@ -50,8 +50,8 @@
 HGLRC WINAPI
 wglCreateContextAttribsARB(HDC hDC, HGLRC hShareContext, const int *attribList)
 {
-   typedef HGLRC (*wglCreateContext_t)(HDC hdc);
-   typedef BOOL (*wglDeleteContext_t)(HGLRC hglrc);
+   typedef HGLRC (WINAPI *wglCreateContext_t)(HDC hdc);
+   typedef BOOL (WINAPI *wglDeleteContext_t)(HGLRC hglrc);
    HGLRC context;
    static HMODULE opengl_lib = 0;
    static wglCreateContext_t wglCreateContext_func = 0;
--
1.7.10.4