[Mesa-stable] [Mesa-dev] [PATCH 1/3 v2] mesa: Handle uninitialized textures like other textures in get_tex_level_parameter_image

Kenneth Graunke kenneth at whitecape.org
Thu Sep 4 14:17:01 PDT 2014


On Wednesday, September 03, 2014 06:50:39 PM Carl Worth wrote:
> Carl Worth <cworth at cworth.org> writes:
> > Emil Velikov <emil.l.velikov at gmail.com> writes:
> >>
> >> I will not have the chance to run piglit on a i965 system until next
> >> week so I would love if someone can take a look at this.
> >
> > I should be able to take a look at this today or tomorrow.
> 
> I didn't see any failures on i965. Oddly, piglit doesn't seem to be
> running this test for me, (maybe I'm missing all glean testing from
> piglit?!---I'll debug that later.).

Glean is excluded by the '-p gbm' option because Glean uses GLUT, not Waffle, and therefore only runs on GLX.  (It has no EGL/X11, Wayland, or GBM support.)

Our plan has been to replace Glean with native Piglit tests.  We've been making some progress toward that, but there's a pile more work to do.

> For now, I'm running this test
> manually with:
> 
> 	./bin/glean -o -v -v -v -t +fragProg1
> 
> >> As a former stable-release manager would you have any suggestions -
> >> should I pull it out from the upcoming 10.2.7 ? I would not be too
> >> fussed it only swrast regresses, yet I'm suspecting that other classic
> >> drivers could be affected.
> >
> > Right. If piglit shows a regression, (on anything), I would recommend
> > not including the patch.
> 
> I still stand by that policy.
> 
> But, while I did find a failure of this test on swrast, I wasn't able to
> identify this patch as a regression. I see this same testing failing
> similarly on both mesa-10.2.6 and 10.2-branchpoint.
> 
> Let me know if I can be of any further assistance.
> 
> -Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-stable/attachments/20140904/dba379a7/attachment.sig>


More information about the mesa-stable mailing list