[Mesa-stable] [PATCH] i965/bdw: Fix 3DSTATE_VF_INSTANCING when the edge flag is used

[Neil Roberts]

Hi Emil,

I posted a v2 of this patch because the v1 wouldn't work in combination
with a fix for bug 84677. I think it would be better to wait for review
on those two and land both of them instead of this patch.

Neither of them are particulary urgent bugs so it's probably not worth
worrying about too much. But of course a bug is a bug so it would be
nice to land them at some point.

http://patchwork.freedesktop.org/patch/54324/
http://patchwork.freedesktop.org/patch/54325/

Regards,
- Neil

Emil Velikov <emil.l.velikov at gmail.com> writes:

> Hello Neil,
>
> On 10 July 2015 at 18:04, Neil Roberts <neil at linux.intel.com> wrote:
>> When the edge flag element is enabled then the elements are slightly
>> reordered so that the edge flag is always the last one. This was
>> confusing the code to upload the 3DSTATE_VF_INSTANCING state because
>> that is uploaded with a separate loop which has an instruction for
>> each element. The indices used in these instructions weren't taking
>> into account the reordering so the state would be incorrect.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91292
>> Cc: "10.6 10.5" <mesa-stable at lists.freedesktop.org>
> Based of Chris's response can you please confirm if there are any
> plans of pushing this patch or alternative approach will be used ?
> I'm going through the list of nominated patches and would like to know
> if we should keep or drop this one.
>
> Thanks
> Emil