[Mesa-stable] [PATCH] auxilary/os: correct sysctl use in os_get_total_physical_memory()
Jonathan Gray
jsg at jsg.id.au
Tue Feb 24 14:48:59 PST 2015
On Tue, Feb 24, 2015 at 04:53:03PM +0000, Emil Velikov wrote:
> On 22 February 2015 at 08:19, Jonathan Gray <jsg at jsg.id.au> wrote:
> > The length argument passed to sysctl was the size of the pointer
> > not the type. The result of this is sysctl calls would fail on
> > 32 bit BSD/Mac OS X.
> >
> > Additionally the wrong pointer was passed as an argument to store
> > the result of the sysctl call.
> >
> > Cc: "10.4, 10.5" <mesa-stable at lists.freedesktop.org>
> > Signed-off-by: Jonathan Gray <jsg at jsg.id.au>
> Seems like my attempt was enough but not quite there yet.
> Thanks for fixing my goof-up.
>
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
>
> I'll push this in a couple of days unless there are any objections.
>
> Cheers
> Emil
It should be possible to use the sysconf path in more places
as well. Classic swrast for example doesn't use sysctl at all.
OpenBSD/FreeBSD have _SC_PHYS_PAGES/_SC_PAGE_SIZE
NetBSD/Mac OS X don't document _SC_PAGE_SIZE but do document
_SC_PAGESIZE, though I wouldn't be surprised if they
had _SC_PAGE_SIZE in their headers.
More information about the mesa-stable
mailing list