[Mesa-stable] [PATCH] mesa: reset the source packing when creating temp transfer image

Iago Toral itoral at igalia.com
Wed Jul 1 23:00:56 PDT 2015


On Wed, 2015-07-01 at 15:18 -0400, Ilia Mirkin wrote:
> Commit 4b249d2ee (mesa: Handle transferOps in texstore_rgba) introduced
> proper transferops handling, but in updating the source to the newly
> allocated temporary image neglected to reset the source packing. Set it
> to the default which should be appropriate for the floats used.
> 
> Fixes: 4b249d2ee (mesa: Handle transferOps in texstore_rgba)
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91173
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> Cc: "10.5 10.6" <mesa-stable at lists.freedesktop.org>

Looks correct to me, thanks for fixing this Ilia:

Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

> ---
>  src/mesa/main/texstore.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c
> index 1525205..37c0569 100644
> --- a/src/mesa/main/texstore.c
> +++ b/src/mesa/main/texstore.c
> @@ -787,6 +787,7 @@ texstore_rgba(TEXSTORE_PARAMS)
>        srcType = GL_FLOAT;
>        srcRowStride = srcWidth * 4 * sizeof(float);
>        srcMesaFormat = RGBA32_FLOAT;
> +      srcPacking = &ctx->DefaultPacking;
>     }
>  
>     src = (GLubyte *)




More information about the mesa-stable mailing list