[Mesa-stable] [Mesa-dev] [PATCH 4/4] i965/fs: Don't issue FB writes for bound but unwritten color targets.

[Emil Velikov]

On 7 March 2015 at 21:35, Jason Ekstrand <jason at jlekstrand.net> wrote:
> On Sat, Mar 7, 2015 at 9:58 AM, Emil Velikov <emil.l.velikov at gmail.com>
> wrote:
>>
>> On 27 February 2015 at 08:06, Kenneth Graunke <kenneth at whitecape.org>
>> wrote:
>> > We used to loop over all color attachments, and emit FB writes for each
>> > one, even if the shader didn't write to a corresponding output variable.
>> > Those color attachments would be filled with garbage (undefined values).
>> >
>> > Football Manager binds a framebuffer with 4 color attachments, but draws
>> > to it using a shader that only writes to gl_FragData[0..2].  This meant
>> > that color attachment 3 would be filled with garbage, resulting in
>> > rendering artifacts.  Now we skip writing to it, fixing rendering.
>> >
>> > Writes to gl_FragColor initialize outputs[0..nr_color_regions-1] to
>> > GRFs, while writes to gl_FragData[i] initialize outputs[i].
>> >
>> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86747
>> > Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
>> > Cc: mesa-stable at lists.freedesktop.org
>> Hi Ken,
>>
>> This commit does not seems to have not landed in master. Did it fall
>> through the cracks ?
>
>
> I think it did.  This series is definitely somethiing we would like to be in
> 10.5
I fear it wasn't :'( Seems like Ken pushed it a couple days after your reply.

commit e95969cd9548033250ba12f2adf11740319b41e7
Author:     Kenneth Graunke <kenneth at whitecape.org>
AuthorDate: Thu Feb 26 17:45:49 2015 -0800
Commit:     Kenneth Graunke <kenneth at whitecape.org>
CommitDate: Mon Mar 9 16:07:04 2015 -0700

    i965/fs: Don't issue FB writes for bound but unwritten color targets.


Thanks gents!
Emil