[Mesa-stable] [PATCH] glsl: fix stream qualifier for blocks with an instance name

Timothy Arceri t_arceri at yahoo.com.au
Thu Nov 5 14:31:56 PST 2015


On Thu, 2015-11-05 at 13:24 +0000, Emil Velikov wrote:
> On 17 October 2015 at 10:51, Timothy Arceri <t_arceri at yahoo.com.au> wrote:
> > This also removes the validation from the parser as it is not required
> > and once arb_enhanced_layouts comes along we wont be able to do validation
> > on the stream qualifier in the parser anyway as it adds constant
> > expression
> > support to the stream qualifier.
> > 
> > Cc: Samuel Iglesias Gonsalvez <siglesias at igalia.com>
> > Cc: 11.0 <mesa-stable at lists.freedesktop.org>
> > ---
> > 
> >  Fixes two new piglit tests I've sent to the piglit list:
> >  http://patchwork.freedesktop.org/patch/62097/
> >  http://patchwork.freedesktop.org/patch/62098/
> > 
> >  src/glsl/ast_to_hir.cpp                   | 26 +++++++++++++++-----------
> >  src/glsl/glsl_parser.yy                   | 11 -----------
> >  src/glsl/lower_named_interface_blocks.cpp |  1 +
> >  3 files changed, 16 insertions(+), 22 deletions(-)
> > 
> Hmm I thought I mentioned it already, but here it goes:
> 
> Tim, can you please provide a fix against 11.0 if we still want this
> in the stable branch.

Hi Emil,

I made a patch that applies cleanly, but it failed the new piglit tests and I
can't be bothered looking into it further so just ignore this for 11.0 no-one
has reported the issues so probably not causing issue anywhere.

Tim

> 
> Thanks
> Emil


More information about the mesa-stable mailing list