[Mesa-stable] [Mesa-dev] [PATCH] nir: fix typo in idiv lowering, causing large-udiv-udiv failures

Eric Anholt eric at anholt.net
Tue Nov 10 15:44:55 PST 2015


Ilia Mirkin <imirkin at alum.mit.edu> writes:

> In nv50, and in the python script that Rob circulated, we do:
>
>    bld.mkCmp(OP_SET, CC_GE, TYPE_U32, (s = bld.getSSA()), TYPE_U32, m, b);
>
> Do the same in the nir div lowering pass. This fixes the large-udiv-udiv
> piglit tests on freedreno.

I assume you meant *-op-div-large-uint-uint.shader_test.

vc4 doesn't have uge yet, but I've got a patch to add it and it does
fix one subtest.  What this lowering pass is actually doing has never
really made sense to me, but it works, so:

Acked-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-stable/attachments/20151110/f7cf8c52/attachment.sig>


More information about the mesa-stable mailing list