[Mesa-stable] [Mesa-dev] [PATCH] targets/dri: android: use WHOLE static libraries

[Emil Velikov]

On 24 November 2015 at 15:06, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Tue, Nov 24, 2015 at 6:57 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> This is bring behaviour similar to whole-archive, where hunks of the
>> static libraries are not discarded and thus the exact order of the
>> libraries does not matter.
>>
>> It has been used in i915/i965 for a very long time, we might want to
>> spare us some headaches and use it as well.
>>
>> This fixes issues with the resent pipe-loader introduction.
>
> Presumably you meant "recent"? Or alternatively "re-sent"? The former
> makes more sense. Since I had to re-read it a few times to get what
> you were talking about, IMHO worth fixing. No comment on the actual
> change.
>
Recent it is..

Thanks for the suggestion - I can see how someone unfamiliar with the
problem will need a couple of reads to understand it.
How does the following sound:

"By using while_static_libraries the android buildsystem provides
whole-archive (alike) solution. This means that we don't need to worry
about the order of the static libraries and any reverse, recursive or
circular dependencies that they have between one another.

Without this the linker will discard any unused hunks of one library
and we'll end up with unresolved symbols as those are required by
another static library. This issue has become more prominent with the
introduction of pipe-loader.

Whole static libraries has been used in i915/i965 for a very long
time, so we might do the same."

Thanks
Emil