[Mesa-stable] [Mesa-dev] [PATCH 1/2] i965: Fix fragment shader struct inputs.

Kenneth Graunke kenneth at whitecape.org
Tue Nov 24 23:03:40 PST 2015


On Tuesday, November 24, 2015 10:35:47 PM Kenneth Graunke wrote:
> Apparently we have literally no support for FS varying struct inputs.
> This is somewhat surprising, given that we've had tests for that very
> feature that have been passing for a long time.
> 
> Normally, varying packing splits up structures for us, so we don't see
> them in the backend.  However, with SSO, varying packing isn't around
> to save us, and we get actual structs that we have to handle.
> 
> This patch changes fs_visitor::emit_general_interpolation() to work
> recursively, properly handling nested structs/arrays/and so on.
> (It's easier to read with diff -b, as indentation changes.)
> 
> When using the vec4 VS backend, this fixes rendering in an upcoming
> game from Feral Interactive.  (The scalar VS backend requires additional
> bug fixes in the next patch.)
> 
> Cc: "11.1 11.0" <mesa-stable at lists.freedesktop.org>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

Hi Emil,

I've pushed an `11.0-records' branch to my tree (~kwg/mesa) with
backports of these patches that apply cleanly to the 11.0 branch.

I verified that 11.0 + the two backports does fix the game, but I
haven't yet done proper regression testing on the backports.  (The
original patches for master do pass the usual testing...)

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-stable/attachments/20151124/583cf71b/attachment.sig>


More information about the mesa-stable mailing list